Added an explicit API for ShouldCallConnectionFailed to make it look like the other methods, even though it is not really needed.

Author: ajcvickers

src/MongoDB.Driver/Core/Connections/BinaryConnection.cs

@@ -155,7 +155,11 @@ private void ConnectionFailed(Exception exception)
             {
                 _failedEventHasBeenRaised = true;
                 _eventLogger.LogAndPublish(new ConnectionFailedEvent(_connectionId, exception));
-                _commandEventHelper.ConnectionFailed(_connectionId, _description?.ServiceId, exception, IsInitializing);
+
+                if (_commandEventHelper.ShouldCallConnectionFailed)
+                {
+                    _commandEventHelper.ConnectionFailed(_connectionId, _description?.ServiceId, exception, IsInitializing);
+                }
             }
         }
 

src/MongoDB.Driver/Core/Connections/CommandEventHelper.cs

@@ -78,6 +78,8 @@ public CommandEventHelper(EventLogger<LogCategories.Command> eventLogger, Tracin
 
         public bool ShouldCallErrorReceiving => _eventsNeedState || ShouldTraceWithActivityListener();
 
+        public bool ShouldCallConnectionFailed => (_shouldTrackFailed || ShouldTraceWithActivityListener()) && _state != null;
+
         private bool ShouldTraceWithActivityListener()
             => !_tracingDisabled && MongoTelemetry.ActivitySource.HasListeners();
 
@@ -227,16 +229,6 @@ public void ErrorReceiving(int responseTo, ConnectionId connectionId, ObjectId?
 
         public void ConnectionFailed(ConnectionId connectionId, ObjectId? serviceId, Exception exception, bool skipLogging)
         {
-            if (!_shouldTrackFailed && !ShouldTraceWithActivityListener())
-            {
-                return;
-            }
-
-            if (_state == null)
-            {
-                return;
-            }
-
             CompleteFailedCommandActivity(exception);
 
             var requestIds = _state.Keys;