Added try catch where needed

Author: papafe

src/MongoDB.Driver/Core/Bindings/CoreTransaction.cs

@@ -135,7 +135,7 @@ internal void SetState(CoreTransactionState state)
         internal void ResetState()
         {
             _state = CoreTransactionState.Starting;
-            _isEmpty = false; //TODO This is wrong
+            _isEmpty = true;
         }
 
         internal void UnpinAll()

src/MongoDB.Driver/Core/Operations/RetryableReadContext.cs

@@ -77,16 +77,34 @@ public void Dispose()
 
         public void AcquireOrReplaceChannel(OperationContext operationContext, IReadOnlyCollection<ServerDescription> deprioritizedServers)
         {
-            operationContext.ThrowIfTimedOutOrCanceled();
-            ReplaceChannelSource(Binding.GetReadChannelSource(operationContext, deprioritizedServers));
-            ReplaceChannel(ChannelSource.GetChannel(operationContext));
+            try
+            {
+                operationContext.ThrowIfTimedOutOrCanceled();
+                ReplaceChannelSource(Binding.GetReadChannelSource(operationContext, deprioritizedServers));
+                ReplaceChannel(ChannelSource.GetChannel(operationContext));
+            }
+            catch
+            {
+                _channelSource?.Dispose();
+                _channel?.Dispose();
+                throw;
+            }
         }
 
         public async Task AcquireOrReplaceChannelAsync(OperationContext operationContext, IReadOnlyCollection<ServerDescription> deprioritizedServers)
         {
-            operationContext.ThrowIfTimedOutOrCanceled();
-            ReplaceChannelSource(await Binding.GetReadChannelSourceAsync(operationContext, deprioritizedServers).ConfigureAwait(false));
-            ReplaceChannel(await ChannelSource.GetChannelAsync(operationContext).ConfigureAwait(false));
+            try
+            {
+                operationContext.ThrowIfTimedOutOrCanceled();
+                ReplaceChannelSource(await Binding.GetReadChannelSourceAsync(operationContext, deprioritizedServers).ConfigureAwait(false));
+                ReplaceChannel(await ChannelSource.GetChannelAsync(operationContext).ConfigureAwait(false));
+            }
+            catch
+            {
+                _channelSource?.Dispose();
+                _channel?.Dispose();
+                throw;
+            }
         }
 
         private void ReplaceChannel(IChannelHandle channel)

src/MongoDB.Driver/Core/Operations/RetryableWriteContext.cs

@@ -78,25 +78,42 @@ public void Dispose()
             }
         }
 
-        //TODO Do this inside the main loop, but remember that this follows reads retryability logic, even with writes
         public void AcquireOrReplaceChannel(OperationContext operationContext, IReadOnlyCollection<ServerDescription> deprioritizedServers, IMayUseSecondaryCriteria mayUseSecondaryCriteria = null)
         {
-            operationContext.ThrowIfTimedOutOrCanceled();
-            var writeChannelSource = mayUseSecondaryCriteria == null  //TODO The implementation of those two overloads is different, I'm worried there some important difference I can't appreciate
-                ? Binding.GetWriteChannelSource(operationContext, deprioritizedServers)
-                : Binding.GetWriteChannelSource(operationContext, deprioritizedServers, mayUseSecondaryCriteria);
-            ReplaceChannelSource(writeChannelSource);
-            ReplaceChannel(ChannelSource.GetChannel(operationContext));
+            try
+            {
+                operationContext.ThrowIfTimedOutOrCanceled();
+                var writeChannelSource = mayUseSecondaryCriteria == null  //TODO The implementation of those two overloads is different, I'm worried there some important difference I can't appreciate
+                    ? Binding.GetWriteChannelSource(operationContext, deprioritizedServers)
+                    : Binding.GetWriteChannelSource(operationContext, deprioritizedServers, mayUseSecondaryCriteria);
+                ReplaceChannelSource(writeChannelSource);
+                ReplaceChannel(ChannelSource.GetChannel(operationContext));
+            }
+            catch
+            {
+                _channelSource?.Dispose();
+                _channel?.Dispose();
+                throw;
+            }
         }
 
         public async Task AcquireOrReplaceChannelAsync(OperationContext operationContext, IReadOnlyCollection<ServerDescription> deprioritizedServers, IMayUseSecondaryCriteria mayUseSecondaryCriteria = null)
         {
-            operationContext.ThrowIfTimedOutOrCanceled();
-            var writeChannelSource = mayUseSecondaryCriteria == null  //TODO The implementation of those two overloads is different, I'm worried there some important difference I can't appreciate
-                ? await Binding.GetWriteChannelSourceAsync(operationContext, deprioritizedServers).ConfigureAwait(false)
-                : await Binding.GetWriteChannelSourceAsync(operationContext, deprioritizedServers, mayUseSecondaryCriteria).ConfigureAwait(false);
-            ReplaceChannelSource(writeChannelSource);
-            ReplaceChannel(await ChannelSource.GetChannelAsync(operationContext).ConfigureAwait(false));
+            try
+            {
+                operationContext.ThrowIfTimedOutOrCanceled();
+                var writeChannelSource = mayUseSecondaryCriteria == null  //TODO The implementation of those two overloads is different, I'm worried there some important difference I can't appreciate
+                    ? await Binding.GetWriteChannelSourceAsync(operationContext, deprioritizedServers).ConfigureAwait(false)
+                    : await Binding.GetWriteChannelSourceAsync(operationContext, deprioritizedServers, mayUseSecondaryCriteria).ConfigureAwait(false);
+                ReplaceChannelSource(writeChannelSource);
+                ReplaceChannel(await ChannelSource.GetChannelAsync(operationContext).ConfigureAwait(false));
+            }
+            catch
+            {
+                _channelSource?.Dispose();
+                _channel?.Dispose();
+                throw;
+            }
         }
 
         private void ReplaceChannel(IChannelHandle channel)

src/MongoDB.Driver/Core/Operations/RetryableWriteOperationExecutor.cs

@@ -72,10 +72,9 @@ public static TResult Execute<TResult>(OperationContext operationContext, IRetry
                 }
                 catch (Exception ex)
                 {
-                    var innerException = ex is MongoAuthenticationException mongoAuthenticationException ? mongoAuthenticationException.InnerException : ex;
                     originalException ??= ex;
 
-                    if (!ShouldRetry(operationContext, operation.WriteConcern, context, server, tokenBucket, innerException, attempt, context.Random, out var backoff))
+                    if (!ShouldRetry(operationContext, operation.WriteConcern, context, server, tokenBucket, ex, attempt, context.Random, out var backoff))
                     {
                         throw originalException;
                     }