CSHARP-6017: Merge LeftJoin translation into JoinMethodToPipelineTranslator

Author: damieng

src/MongoDB.Driver/Linq/Linq3Implementation/Translators/ExpressionToPipelineTranslators/ExpressionToPipelineTranslator.cs

@@ -51,9 +51,8 @@ public static TranslatedPipeline Translate(TranslationContext context, Expressio
                 case "GroupJoin":
                     return GroupJoinMethodToPipelineTranslator.Translate(context, methodCallExpression);
                 case "Join":
-                    return JoinMethodToPipelineTranslator.Translate(context, methodCallExpression);
                 case "LeftJoin":
-                    return LeftJoinMethodToPipelineTranslator.Translate(context, methodCallExpression);
+                    return JoinMethodToPipelineTranslator.Translate(context, methodCallExpression);
                 case "Lookup":
                     return LookupMethodToPipelineTranslator.Translate(context, methodCallExpression);
                 case "OfType":

src/MongoDB.Driver/Linq/Linq3Implementation/Translators/ExpressionToPipelineTranslators/JoinMethodToPipelineTranslator.cs

@@ -1,4 +1,4 @@
-/* Copyright 2010-present MongoDB Inc.
+/* Copyright 2010-present MongoDB Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -13,6 +13,8 @@
 * limitations under the License.
 */
 
+using System.Collections.Generic;
+using System.Linq;
 using System.Linq.Expressions;
 using MongoDB.Bson.Serialization;
 using MongoDB.Driver.Linq.Linq3Implementation.Ast;
@@ -34,7 +36,8 @@ public static TranslatedPipeline Translate(TranslationContext context, MethodCal
             var method = expression.Method;
             var arguments = expression.Arguments;
 
-            if (method.Is(QueryableMethod.Join))
+            var isLeftJoin = method.IsOneOf(MongoQueryableMethod.LeftJoin, QueryableMethod.LeftJoin);
+            if (isLeftJoin || method.Is(QueryableMethod.Join))
             {
                 var outerExpression = arguments[0];
                 var innerExpression = arguments[1];
@@ -58,6 +61,11 @@ public static TranslatedPipeline Translate(TranslationContext context, MethodCal
                     outerSerializer = pipeline.OutputSerializer;
                 }
 
+                if (isLeftJoin)
+                {
+                    ThrowIfReservedFieldNames(expression, outerSerializer);
+                }
+
                 var wrapOuterStage = AstStage.Project(
                     AstProject.Set("_outer", outerAst),
                     AstProject.Exclude("_id"));
@@ -73,7 +81,7 @@ public static TranslatedPipeline Translate(TranslationContext context, MethodCal
                     foreignField,
                     @as: "_inner");
 
-                var unwindStage = AstStage.Unwind("_inner");
+                var unwindStage = AstStage.Unwind("_inner", preserveNullAndEmptyArrays: isLeftJoin);
 
                 var outerParameter = resultSelectorLambda.Parameters[0];
                 var outerField = AstExpression.GetField(AstExpression.RootVar, "_outer");
@@ -97,5 +105,29 @@ public static TranslatedPipeline Translate(TranslationContext context, MethodCal
 
             throw new ExpressionNotSupportedException(expression);
         }
+
+        private static readonly HashSet<string> __reservedFieldNames = new HashSet<string> { "_outer", "_inner" };
+
+        private static void ThrowIfReservedFieldNames(MethodCallExpression expression, IBsonSerializer serializer)
+        {
+            if (serializer is not IBsonDocumentSerializer documentSerializer)
+                return;
+
+            var conflicting = new List<string>();
+            foreach (var member in serializer.ValueType.GetMembers())
+            {
+                if (documentSerializer.TryGetMemberSerializationInfo(member.Name, out var info) &&
+                    __reservedFieldNames.Contains(info.ElementName))
+                {
+                    conflicting.Add(info.ElementName);
+                }
+            }
+
+            if (conflicting.Count > 0)
+            {
+                throw new ExpressionNotSupportedException(expression,
+                    because: $"the outer document type uses reserved field name(s) {string.Join(", ", conflicting.Select(n => $"'{n}'"))} which are used internally by LeftJoin");
+            }
+        }
     }
 }