CSHARP-5894: Prevent deadlock during multi-theaded BsonClassMap serializer resolution

src/MongoDB.Bson/Serialization/Serializers/DictionarySerializerBase.cs

@@ -420,8 +420,8 @@ public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentatio
         public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentation, IBsonSerializerRegistry serializerRegistry)
             : this(
                 dictionaryRepresentation,
-                new Lazy<IBsonSerializer<TKey>>(() => serializerRegistry.GetSerializer<TKey>()),
-                new Lazy<IBsonSerializer<TValue>>(() => serializerRegistry.GetSerializer<TValue>()))
+                Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TKey>()),
+                Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TValue>()))
         {
             if (serializerRegistry == null)
             {

src/MongoDB.Bson/Serialization/Serializers/EnumerableSerializerBase.cs

@@ -64,7 +64,7 @@ protected EnumerableSerializerBase(IBsonSerializerRegistry serializerRegistry)
                 throw new ArgumentNullException("serializerRegistry");
             }
 
-            _lazyItemSerializer = new Lazy<IBsonSerializer>(() => serializerRegistry.GetSerializer(typeof(object)));
+            _lazyItemSerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer(typeof(object)));
         }
 
         /// <summary>
@@ -263,7 +263,7 @@ protected EnumerableSerializerBase(IBsonSerializerRegistry serializerRegistry)
                 throw new ArgumentNullException("serializerRegistry");
             }
 
-            _lazyItemSerializer = new Lazy<IBsonSerializer<TItem>>(() => serializerRegistry.GetSerializer<TItem>());
+            _lazyItemSerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TItem>());
         }
 
         // public properties

src/MongoDB.Bson/Serialization/Serializers/IEnumerableDeserializingAsCollectionSerializer.cs

@@ -81,7 +81,7 @@ public IEnumerableDeserializingAsCollectionSerializer(IBsonSerializerRegistry se
                 throw new ArgumentNullException(nameof(serializerRegistry));
             }
 
-            _lazyItemSerializer = new Lazy<IBsonSerializer<TItem>>(serializerRegistry.GetSerializer<TItem>);
+            _lazyItemSerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TItem>());
         }
 
         // public properties

src/MongoDB.Bson/Serialization/Serializers/ImpliedImplementationInterfaceSerializer.cs

@@ -74,7 +74,7 @@ public ImpliedImplementationInterfaceSerializer(IBsonSerializer<TImplementation>
         /// </summary>
         /// <param name="serializerRegistry">The serializer registry.</param>
         public ImpliedImplementationInterfaceSerializer(IBsonSerializerRegistry serializerRegistry)
-            : this(new Lazy<IBsonSerializer<TImplementation>>(() => serializerRegistry.GetSerializer<TImplementation>()))
+            : this(Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TImplementation>()))
         {
             if (serializerRegistry == null)
             {

src/MongoDB.Bson/Serialization/Serializers/KeyValuePairSerializer.cs

@@ -124,8 +124,8 @@ public KeyValuePairSerializer(BsonType representation, IBsonSerializer<TKey> key
         public KeyValuePairSerializer(BsonType representation, IBsonSerializerRegistry serializerRegistry)
             : this(
                 representation,
-                new Lazy<IBsonSerializer<TKey>>(() => serializerRegistry.GetSerializer<TKey>()),
-                new Lazy<IBsonSerializer<TValue>>(() => serializerRegistry.GetSerializer<TValue>()))
+                Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TKey>()),
+                Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TValue>()))
         {
             if (serializerRegistry == null)
             {

src/MongoDB.Bson/Serialization/Serializers/Lazy.cs

@@ -0,0 +1,33 @@
+/* Copyright 2010-present MongoDB Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+using System.Threading;
+
+namespace MongoDB.Bson.Serialization.Serializers;
+
+internal static class Lazy
+{
+    /// <summary>
+    /// Creates a <see cref="Lazy{T}"/> with <see cref="LazyThreadSafetyMode.PublicationOnly"/>.
+    /// </summary>
+    /// <typeparam name="T">The type of the lazily initialized value.</typeparam>
+    /// <param name="valueFactory">The factory delegate that produces the value.</param>
+    /// <returns>A <see cref="Lazy{T}"/> configured with <see cref="LazyThreadSafetyMode.PublicationOnly"/>.</returns>
+    public static Lazy<T> CreatePublicationOnly<T>(Func<T> valueFactory)
+    {
+        return new Lazy<T>(valueFactory, LazyThreadSafetyMode.PublicationOnly);
+    }
+}

src/MongoDB.Bson/Serialization/Serializers/NullableSerializer.cs

@@ -160,7 +160,7 @@ public NullableSerializer(IBsonSerializerRegistry serializerRegistry)
                 throw new ArgumentNullException("serializerRegistry");
             }
 
-            _lazySerializer = new Lazy<IBsonSerializer<T>>(() => serializerRegistry.GetSerializer<T>());
+            _lazySerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T>());
         }
 
         // public properties

src/MongoDB.Bson/Serialization/Serializers/SerializeAsNominalTypeSerializer.cs

@@ -61,7 +61,7 @@ public SerializeAsNominalTypeSerializer(IBsonSerializerRegistry serializerRegist
                 throw new ArgumentNullException("serializerRegistry");
             }
 
-            _lazyNominalTypeSerializer = new Lazy<IBsonSerializer<TNominalType>>(() => serializerRegistry.GetSerializer<TNominalType>());
+            _lazyNominalTypeSerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TNominalType>());
         }
 
         // public methods

src/MongoDB.Bson/Serialization/Serializers/ThreeDimensionalArraySerializer.cs

@@ -63,7 +63,7 @@ public ThreeDimensionalArraySerializer(IBsonSerializerRegistry serializerRegistr
                 throw new ArgumentNullException("serializerRegistry");
             }
 
-            _lazyItemSerializer = new Lazy<IBsonSerializer<TItem>>(() => serializerRegistry.GetSerializer<TItem>());
+            _lazyItemSerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TItem>());
         }
 
         // public properties

src/MongoDB.Bson/Serialization/Serializers/TupleSerializers.cs

@@ -138,7 +138,7 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException(nameof(serializerRegistry)); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
         }
 
         // public properties
@@ -236,8 +236,8 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException("serializerRegistry"); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
-            _lazyItem2Serializer = new Lazy<IBsonSerializer<T2>>(() => serializerRegistry.GetSerializer<T2>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem2Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T2>());
         }
 
         // public properties
@@ -350,9 +350,9 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException(nameof(serializerRegistry)); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
-            _lazyItem2Serializer = new Lazy<IBsonSerializer<T2>>(() => serializerRegistry.GetSerializer<T2>());
-            _lazyItem3Serializer = new Lazy<IBsonSerializer<T3>>(() => serializerRegistry.GetSerializer<T3>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem2Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T2>());
+            _lazyItem3Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T3>());
         }
 
         // public properties
@@ -479,10 +479,10 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException(nameof(serializerRegistry)); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
-            _lazyItem2Serializer = new Lazy<IBsonSerializer<T2>>(() => serializerRegistry.GetSerializer<T2>());
-            _lazyItem3Serializer = new Lazy<IBsonSerializer<T3>>(() => serializerRegistry.GetSerializer<T3>());
-            _lazyItem4Serializer = new Lazy<IBsonSerializer<T4>>(() => serializerRegistry.GetSerializer<T4>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem2Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T2>());
+            _lazyItem3Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T3>());
+            _lazyItem4Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T4>());
         }
 
         // public properties
@@ -625,11 +625,11 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException(nameof(serializerRegistry)); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
-            _lazyItem2Serializer = new Lazy<IBsonSerializer<T2>>(() => serializerRegistry.GetSerializer<T2>());
-            _lazyItem3Serializer = new Lazy<IBsonSerializer<T3>>(() => serializerRegistry.GetSerializer<T3>());
-            _lazyItem4Serializer = new Lazy<IBsonSerializer<T4>>(() => serializerRegistry.GetSerializer<T4>());
-            _lazyItem5Serializer = new Lazy<IBsonSerializer<T5>>(() => serializerRegistry.GetSerializer<T5>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem2Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T2>());
+            _lazyItem3Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T3>());
+            _lazyItem4Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T4>());
+            _lazyItem5Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T5>());
         }
 
         // public properties
@@ -787,12 +787,12 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException("serializerRegistry"); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
-            _lazyItem2Serializer = new Lazy<IBsonSerializer<T2>>(() => serializerRegistry.GetSerializer<T2>());
-            _lazyItem3Serializer = new Lazy<IBsonSerializer<T3>>(() => serializerRegistry.GetSerializer<T3>());
-            _lazyItem4Serializer = new Lazy<IBsonSerializer<T4>>(() => serializerRegistry.GetSerializer<T4>());
-            _lazyItem5Serializer = new Lazy<IBsonSerializer<T5>>(() => serializerRegistry.GetSerializer<T5>());
-            _lazyItem6Serializer = new Lazy<IBsonSerializer<T6>>(() => serializerRegistry.GetSerializer<T6>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem2Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T2>());
+            _lazyItem3Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T3>());
+            _lazyItem4Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T4>());
+            _lazyItem5Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T5>());
+            _lazyItem6Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T6>());
         }
 
         // public properties
@@ -965,13 +965,13 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException(nameof(serializerRegistry)); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
-            _lazyItem2Serializer = new Lazy<IBsonSerializer<T2>>(() => serializerRegistry.GetSerializer<T2>());
-            _lazyItem3Serializer = new Lazy<IBsonSerializer<T3>>(() => serializerRegistry.GetSerializer<T3>());
-            _lazyItem4Serializer = new Lazy<IBsonSerializer<T4>>(() => serializerRegistry.GetSerializer<T4>());
-            _lazyItem5Serializer = new Lazy<IBsonSerializer<T5>>(() => serializerRegistry.GetSerializer<T5>());
-            _lazyItem6Serializer = new Lazy<IBsonSerializer<T6>>(() => serializerRegistry.GetSerializer<T6>());
-            _lazyItem7Serializer = new Lazy<IBsonSerializer<T7>>(() => serializerRegistry.GetSerializer<T7>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem2Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T2>());
+            _lazyItem3Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T3>());
+            _lazyItem4Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T4>());
+            _lazyItem5Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T5>());
+            _lazyItem6Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T6>());
+            _lazyItem7Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T7>());
         }
 
         // public properties
@@ -1159,14 +1159,14 @@ public TupleSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             if (serializerRegistry == null) { throw new ArgumentNullException(nameof(serializerRegistry)); }
 
-            _lazyItem1Serializer = new Lazy<IBsonSerializer<T1>>(() => serializerRegistry.GetSerializer<T1>());
-            _lazyItem2Serializer = new Lazy<IBsonSerializer<T2>>(() => serializerRegistry.GetSerializer<T2>());
-            _lazyItem3Serializer = new Lazy<IBsonSerializer<T3>>(() => serializerRegistry.GetSerializer<T3>());
-            _lazyItem4Serializer = new Lazy<IBsonSerializer<T4>>(() => serializerRegistry.GetSerializer<T4>());
-            _lazyItem5Serializer = new Lazy<IBsonSerializer<T5>>(() => serializerRegistry.GetSerializer<T5>());
-            _lazyItem6Serializer = new Lazy<IBsonSerializer<T6>>(() => serializerRegistry.GetSerializer<T6>());
-            _lazyItem7Serializer = new Lazy<IBsonSerializer<T7>>(() => serializerRegistry.GetSerializer<T7>());
-            _lazyRestSerializer = new Lazy<IBsonSerializer<TRest>>(() => serializerRegistry.GetSerializer<TRest>());
+            _lazyItem1Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T1>());
+            _lazyItem2Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T2>());
+            _lazyItem3Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T3>());
+            _lazyItem4Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T4>());
+            _lazyItem5Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T5>());
+            _lazyItem6Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T6>());
+            _lazyItem7Serializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<T7>());
+            _lazyRestSerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TRest>());
         }
 
         // public properties

src/MongoDB.Bson/Serialization/Serializers/TwoDimensionalArraySerializer.cs

@@ -63,7 +63,7 @@ public TwoDimensionalArraySerializer(IBsonSerializerRegistry serializerRegistry)
                 throw new ArgumentNullException("serializerRegistry");
             }
 
-            _lazyItemSerializer = new Lazy<IBsonSerializer<TItem>>(() => serializerRegistry.GetSerializer<TItem>());
+            _lazyItemSerializer = Lazy.CreatePublicationOnly(() => serializerRegistry.GetSerializer<TItem>());
         }
 
         // public properties