Skip to content

CSHARP-5871: Clarify phase description for "Network timeouts test" spec test #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanych-sun merged 1 commit into from
Apr 10, 2026
Merged

CSHARP-5871: Clarify phase description for "Network timeouts test" spec test #1919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions specifications/server-discovery-and-monitoring/tests/errors/error_handling_handshake.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
}
},
{
"description": "Mark server unknown on network timeout application error (beforeHandshakeCompletes)",
"description": "Ignore network timeout application error (beforeHandshakeCompletes)",
"applicationErrors": [
{
"address": "a:27017",
Expand All @@ -97,14 +97,22 @@
"outcome": {
"servers": {
"a:27017": {
"type": "Unknown",
"topologyVersion": null,
"type": "RSPrimary",
"setName": "rs",
"topologyVersion": {
"processId": {
"$oid": "000000000000000000000001"
},
"counter": {
"$numberLong": "1"
}
},
"pool": {
"generation": 1
"generation": 0
}
}
},
"topologyType": "ReplicaSetNoPrimary",
"topologyType": "ReplicaSetWithPrimary",
"logicalSessionTimeoutMinutes": null,
"setName": "rs"
}
Expand Down
15 changes: 4 additions & 11 deletions specifications/server-discovery-and-monitoring/tests/errors/error_handling_handshake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,12 @@ phases:
type: timeout
outcome: *outcome

- description: Mark server unknown on network timeout application error (beforeHandshakeCompletes)
- description: Ignore network timeout application error (beforeHandshakeCompletes)
# The test runner may need to add the SystemOverloadedError label for the pre-handshake network timeout.
# The SystemOverloadedError label causes the error to be ignored.
applicationErrors:
- address: a:27017
when: beforeHandshakeCompletes
maxWireVersion: 9
type: timeout
outcome:
servers:
a:27017:
type: Unknown
topologyVersion: null
pool:
generation: 1
topologyType: ReplicaSetNoPrimary
logicalSessionTimeoutMinutes: null
setName: rs
outcome: *outcome
1 change: 1 addition & 0 deletions .../Specifications/server-discovery-and-monitoring/ServerDiscoveryAndMonitoringTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ private void ApplyApplicationError(BsonDocument applicationError)
{
var innerException = CoreExceptionHelper.CreateException("IOExceptionWithTimedOutSocketException");
simulatedException = new MongoConnectionException(connectionId, "Chaos, yet harmony.", innerException);
((MongoConnectionException)simulatedException).AddErrorLabel("SystemOverloadedError");
break;
}
default:
Expand Down
Loading