CSHARP-4931 Add tests for SortDefinitionExtensions#1935
Merged
kyra-rk merged 4 commits intomongodb:mainfrom Apr 8, 2026
Merged
CSHARP-4931 Add tests for SortDefinitionExtensions#1935kyra-rk merged 4 commits intomongodb:mainfrom
kyra-rk merged 4 commits intomongodb:mainfrom
Conversation
kyra-rk
added
the
improvement
papafe
requested changes
Apr 7, 2026
Contributor
papafe
left a comment
papafe
left a comment
There was a problem hiding this comment.
Looks good, just a small comment.
| } | ||
|
|
||
| [Fact] | ||
| public void Ascending_typed_using_extension_methods() |
Contributor
There was a problem hiding this comment.
Ascending_Typed.... (just to keep consistency)
papafe
approved these changes
Apr 8, 2026
Contributor
papafe
left a comment
papafe
left a comment
There was a problem hiding this comment.
LGTM. Let's just wait for evergreen before merging.
papafe
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.