Skip to content

CSHARP-2868 Allow maxIdleTimeMS=0 and treat it as no idle time limit #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyra-rk wants to merge 5 commits into
base: main
Choose a base branch
from
Open

CSHARP-2868 Allow maxIdleTimeMS=0 and treat it as no idle time limit #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8772b6
allow 0 and make it no limit, but still need to test that no limit (m…
kyra-rk Apr 3, 2026
53b2b10
add tests to cover isexpired new logic
kyra-rk Apr 3, 2026
e89f1ee
tweak tests to actually test the right return branch
kyra-rk Apr 3, 2026
e77c835
removed sleep and comment
kyra-rk Apr 3, 2026
c255910
add test coverage for max idle time = 0 behaviour in mongo url builde…
kyra-rk Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MongoDB.Driver/Core/Configuration/ConnectionSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public ConnectionSettings(
_connectionIdLocalValueProvider = LongIdGenerator<ConnectionId>.GetNextId;
_libraryInfo = libraryInfo.WithDefault(null);
_loadBalanced = loadBalanced.WithDefault(false);
_maxIdleTime = Ensure.IsGreaterThanZero(maxIdleTime.WithDefault(TimeSpan.FromMinutes(10)), "maxIdleTime");
_maxIdleTime = Ensure.IsGreaterThanOrEqualToZero(maxIdleTime.WithDefault(TimeSpan.FromMinutes(10)), "maxIdleTime");
_maxLifeTime = Ensure.IsGreaterThanZero(maxLifeTime.WithDefault(TimeSpan.FromMinutes(30)), "maxLifeTime");
_applicationName = ApplicationNameHelper.EnsureApplicationNameIsValid(applicationName.WithDefault(null), nameof(applicationName));
}
Expand All @@ -79,7 +79,7 @@ internal ConnectionSettings(
_connectionIdLocalValueProvider = connectionIdLocalValueProvider.WithDefault(LongIdGenerator<ConnectionId>.GetNextId);
_libraryInfo = libraryInfo.WithDefault(null);
_loadBalanced = loadBalanced.WithDefault(false);
_maxIdleTime = Ensure.IsGreaterThanZero(maxIdleTime.WithDefault(TimeSpan.FromMinutes(10)), "maxIdleTime");
_maxIdleTime = Ensure.IsGreaterThanOrEqualToZero(maxIdleTime.WithDefault(TimeSpan.FromMinutes(10)), "maxIdleTime");
_maxLifeTime = Ensure.IsGreaterThanZero(maxLifeTime.WithDefault(TimeSpan.FromMinutes(30)), "maxLifeTime");
_applicationName = ApplicationNameHelper.EnsureApplicationNameIsValid(applicationName.WithDefault(null), nameof(applicationName));
}
Expand Down
2 changes: 1 addition & 1 deletion src/MongoDB.Driver/Core/Connections/BinaryConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public bool IsExpired
}

// connection has been idle for too long
if (_settings.MaxIdleTime.TotalMilliseconds > -1 && now > _lastUsedAtUtc.Add(_settings.MaxIdleTime))
if (_settings.MaxIdleTime.TotalMilliseconds > 0 && now > _lastUsedAtUtc.Add(_settings.MaxIdleTime))
{
return true;
}
Expand Down
16 changes: 10 additions & 6 deletions tests/MongoDB.Driver.Tests/Core/Configuration/ConnectionSettingsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,21 @@ public void constructor_should_throw_when_compressors_is_null()
e.ParamName.Should().Be("compressors");
}

[Theory]
[ParameterAttributeData]
public void constructor_should_throw_when_maxIdleTime_is_negative_or_zero(
[Values(-1, 0)]
int maxIdleTime)
[Fact]
public void constructor_should_throw_when_maxIdleTime_is_negative()
{
Action action = () => new ConnectionSettings(maxIdleTime: TimeSpan.FromSeconds(maxIdleTime));
Action action = () => new ConnectionSettings(maxIdleTime: TimeSpan.FromSeconds(-1));

action.ShouldThrow<ArgumentException>().And.ParamName.Should().Be("maxIdleTime");
}

[Fact]
public void constructor_should_not_throw_when_maxIdleTime_is_zero()
{
var subject = new ConnectionSettings(maxIdleTime: TimeSpan.FromSeconds(0));
subject.MaxIdleTime.Should().Be(TimeSpan.Zero);
}

[Theory]
[ParameterAttributeData]
public void constructor_should_throw_when_maxLifeTime_is_negative_or_zero(
Expand Down
38 changes: 38 additions & 0 deletions tests/MongoDB.Driver.Tests/Core/Connections/BinaryConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,44 @@ public async Task SendMessage_should_put_the_message_on_the_stream_and_raise_the
}
}

[Fact]
public void IsExpired_should_return_false_when_maxIdleTime_has_no_limit()
{
var subject = new BinaryConnection(
serverId: _serverId,
endPoint: _endPoint,
settings: new ConnectionSettings(maxIdleTime: TimeSpan.FromMilliseconds(0)),
streamFactory: _mockStreamFactory.Object,
connectionInitializer: _mockConnectionInitializer.Object,
eventSubscriber: _capturedEvents,
loggerFactory: LoggerFactory,
tracingOptions: null,
socketReadTimeout: TimeSpan.FromMilliseconds(1000),
socketWriteTimeout: TimeSpan.FromMilliseconds(1000));

subject.Open(OperationContext.NoTimeout);
subject.IsExpired.Should().BeFalse();
}

[Fact]
public void IsExpired_should_return_true_when_maxIdleTime_is_exceeded()
{
var subject = new BinaryConnection(
serverId: _serverId,
endPoint: _endPoint,
settings: new ConnectionSettings(maxIdleTime: TimeSpan.FromMilliseconds(10), maxLifeTime: TimeSpan.FromMinutes(10)),
streamFactory: _mockStreamFactory.Object,
connectionInitializer: _mockConnectionInitializer.Object,
eventSubscriber: _capturedEvents,
loggerFactory: LoggerFactory,
tracingOptions: null,
socketReadTimeout: TimeSpan.FromMilliseconds(1000),
socketWriteTimeout: TimeSpan.FromMilliseconds(1000));

subject.Open(OperationContext.NoTimeout);
subject.IsExpired.Should().BeTrue();
}

private void SetupStreamRead(Mock<Stream> streamMock, TaskCompletionSource<int> tcs)
{
streamMock.Setup(s => s.Read(It.IsAny<byte[]>(), It.IsAny<int>(), It.IsAny<int>()))
Expand Down
1 change: 1 addition & 0 deletions tests/MongoDB.Driver.Tests/MongoUrlBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,7 @@ public void TestMaxConnecting([Values(0, -1)] int incorrectMaxConnecting)

[Theory]
[InlineData(null, "mongodb://localhost", new[] { "" })]
[InlineData(0, "mongodb://localhost/?maxIdleTime{0}", new[] { "=0h", "MS=0", "=0ms", "=0" })]
[InlineData(500, "mongodb://localhost/?maxIdleTime{0}", new[] { "=500ms", "=0.5", "=0.5s", "=00:00:00.5", "MS=500" })]
[InlineData(30000, "mongodb://localhost/?maxIdleTime{0}", new[] { "=30s", "=30000ms", "=30", "=0.5m", "=00:00:30", "MS=30000" })]
[InlineData(1800000, "mongodb://localhost/?maxIdleTime{0}", new[] { "=30m", "=1800000ms", "=1800", "=1800s", "=0.5h", "=00:30:00", "MS=1800000" })]
Expand Down