CSHARP-5825: Support (de)serialization between BSON and EJSON#1939
CSHARP-5825: Support (de)serialization between BSON and EJSON#1939papafe wants to merge 2 commits intomongodb:mainfrom
Conversation
…ization between BSON and EJSON
There was a problem hiding this comment.
The new methods in this file break the alphabetical ordering.
| DeserializeEJsonExpression, | ||
| DateAddExpression, |
There was a problem hiding this comment.
nit: DateAddExpression should come before DeserializeEJsonExpression.
| private static readonly MethodInfo __deserializeEJson; | ||
| private static readonly MethodInfo __dateFromStringWithFormat; |
There was a problem hiding this comment.
__dateFromStringWithFormat (and the other __dateFromString* variants) should all appear before __deserializeEJson .
Same issue in the public properties section (lines 113-117): DeserializeEJson is wedged between DateFromString and DateFromStringWithFormat*.
| private bool? _relaxed; | ||
|
|
||
| /// <summary> | ||
| /// The relaxed parameter. When true, produces relaxed Extended JSON format. When false, produces canonical format. Defaults to true. |
There was a problem hiding this comment.
The sentence "Defaults to true" could be misread as "this C# property defaults to true." The property defaults to null (not set). The server defaults to true when the parameter is omitted. I would suggest clarifying: "The server defaults to true when this is not specified."
2 participants
No description provided.