CSHARP-6029: Make ICoreServerSessionPool disposable and send endSessions on dispose - fix failing tests#2010
Merged
Merged
Conversation
…ons on dispose - fix failing tests
sanych-sun
added
the
chore
Contributor
There was a problem hiding this comment.
Pull request overview
Updates session-pool shutdown behavior and aligns OpenTelemetry smoke test expectations with the additional activity emitted during cluster disposal.
Changes:
- Avoids attempting to create/pop a zero-length session batch when disposing the server session pool.
- Updates OpenTelemetry smoke test activity counts to reflect the additional command activity during disposal.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/SmokeTests/MongoDB.Driver.SmokeTests.Sdk/OpenTelemetryTests.cs | Updates expected captured activity totals after disposal now emits an additional command activity. |
| src/MongoDB.Driver/Core/Bindings/CoreServerSessionPool.cs | Adds an early exit when the pool is empty to avoid zero-sized batch handling during disposal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.