Skip to content

CSHARP-6069: Add await to async tests missing await #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BorisDog merged 2 commits into from
Jun 6, 2026
Merged

CSHARP-6069: Add await to async tests missing await #2028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685d7fa
CSHARP-6069: Add await to async tests missing await
mongodb-sage-bot[bot] Jun 5, 2026
e0d3845
CSHARP-6069: Use Record.ExceptionAsync pattern in EstimatedDocumentCo…
mongodb-sage-bot[bot] Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/MongoDB.Driver.Tests/IMongoClientExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/

using System.Threading;
using System.Threading.Tasks;
using MongoDB.Bson;
using MongoDB.TestHelpers.XunitExtensions;
using Moq;
Expand All @@ -25,7 +26,7 @@ public class IMongoClientExtensionsTests
{
[Theory]
[ParameterAttributeData]
public void Watch_should_call_client_with_expected_arguments(
public async Task Watch_should_call_client_with_expected_arguments(
[Values(false, true)] bool usingSession,
[Values(false, true)] bool async)
{
Expand All @@ -40,7 +41,7 @@ public void Watch_should_call_client_with_expected_arguments(
{
if (async)
{
client.WatchAsync(session, options, cancellationToken);
await client.WatchAsync(session, options, cancellationToken);
mockClient.Verify(m => m.WatchAsync(session, It.IsAny<EmptyPipelineDefinition<ChangeStreamDocument<BsonDocument>>>(), options, cancellationToken), Times.Once);
}
else
Expand All @@ -53,7 +54,7 @@ public void Watch_should_call_client_with_expected_arguments(
{
if (async)
{
client.WatchAsync(options, cancellationToken);
await client.WatchAsync(options, cancellationToken);
mockClient.Verify(m => m.WatchAsync(It.IsAny<EmptyPipelineDefinition<ChangeStreamDocument<BsonDocument>>>(), options, cancellationToken), Times.Once);
}
else
Expand Down
7 changes: 4 additions & 3 deletions tests/MongoDB.Driver.Tests/IMongoDatabaseExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/

using System.Threading;
using System.Threading.Tasks;
using MongoDB.Bson;
using MongoDB.TestHelpers.XunitExtensions;
using Moq;
Expand All @@ -25,7 +26,7 @@ public class IMongoDatabaseExtensionsTests
{
[Theory]
[ParameterAttributeData]
public void Watch_should_call_client_with_expected_arguments(
public async Task Watch_should_call_client_with_expected_arguments(
[Values(false, true)] bool usingSession,
[Values(false, true)] bool async)
{
Expand All @@ -40,7 +41,7 @@ public void Watch_should_call_client_with_expected_arguments(
{
if (async)
{
database.WatchAsync(session, options, cancellationToken);
await database.WatchAsync(session, options, cancellationToken);
mockDatabase.Verify(m => m.WatchAsync(session, It.IsAny<EmptyPipelineDefinition<ChangeStreamDocument<BsonDocument>>>(), options, cancellationToken), Times.Once);
}
else
Expand All @@ -53,7 +54,7 @@ public void Watch_should_call_client_with_expected_arguments(
{
if (async)
{
database.WatchAsync(options, cancellationToken);
await database.WatchAsync(options, cancellationToken);
mockDatabase.Verify(m => m.WatchAsync(It.IsAny<EmptyPipelineDefinition<ChangeStreamDocument<BsonDocument>>>(), options, cancellationToken), Times.Once);
}
else
Expand Down
Loading