CXX-3439 Add maxAdaptiveRetries and enableOverloadRetargeting URI fields#1612
Merged
Conversation
kevinAlbs
approved these changes
Apr 21, 2026
eramongodb
changed the title
maxAdaptiveRetries field to URI optionsmaxAdaptiveRetries and enableOverloadRetargeting URI fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3439 (CXX-3328) as followup to CDRIVER-6274 (CDRIVER-6073) and CXX-3468.
Because most changes required by the relevant JIRA issues pertain to internal (C driver) behavior or tests which the C++ driver does not implement (due to redundancy or due to blocked-on status), the only meaningful changes required for the C++ driver is extending support for querying URI options (read-only API) to include the new "maxAdaptiveRetries" and "enableOverloadRetargeting" fields.
Extending test coverage to account for these two options reveal inconsistent handling of invalid values relative to other int32 and bool fields following mongodb/mongo-c-driver#2269 (comment), where
mongoc_uri_get_option_as_int32()is deliberately unused to avoid0-special-casing, but also demoted the behavior of invalid values from "error" to "warn and ignore". This manifests as the unexpected absence of exceptions throw by the URI constructor(s) relative to the_test_int32_options()and_test_bool_options()test helper functions (discrepancies marked with "NOT an error" comments for clarity).