Make bson-enum_error resilient to PHP 8.6 interface handler order#1953
Conversation
There was a problem hiding this comment.
Pull request overview
Updates a BSON enum error PHPT to be resilient to PHP 8.6’s changed interface_gets_implemented handler order, which can alter which interface name appears in the fatal error message.
Changes:
- Switches the test expectation from
--EXPECTF--to--EXPECTREGEX--. - Allows either
MongoDB\BSON\PersistableorMongoDB\BSON\Unserializableto appear in the fatal error output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
PHP is calling the interface_gets_implemented handlers in a different order
5130bc0 to
bacbd5b
Compare
Small correction: mongo-php-driver/src/BSON/Persistable.c Lines 24 to 32 in 383bfbf |
|
Since the check is done in both interfaces, and that's Or we can try to improve the exception message in |
…ngodb#1953) PHP is calling the interface_gets_implemented handlers in a different order
PHP is calling the
interface_gets_implementedhandlers in a different order since php/php-src#18622Build failure detected in #1952 (comment)
The
Persistableinterface extendsUnserializablewhich is the one that cannot be implemented.