PHPC-1514 Remove php_phongo_read_concern_to_zval

[paulinevos]

Fix PHPC-1514
It's only used by the Query debug handler and can be replaced by adding a ReadConcern object to Query's debug info instead

[Copilot]

Pull request overview

Removes the internal phongo_read_concern_to_zval helper by switching MongoDB\Driver\Query’s debug handler to expose a MongoDB\Driver\ReadConcern object directly in debug info.

Changes:

• Remove phongo_read_concern_to_zval declaration and implementation.
• Update Query debug info to use phongo_readconcern_init() and attach a ReadConcern object instead of an array.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/MongoDB/ReadConcern.h	Drops the removed helper’s declaration.
src/MongoDB/ReadConcern.c	Drops the removed helper’s implementation.
src/MongoDB/Query.c	Uses phongo_readconcern_init() for readConcern debug info.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[GromNaN]

I'm surprised that a test like tests/query/query-debug-001.phpt doesn't fail. The format has changed from an array to an instance of ReadConcern.

[paulinevos]

@GromNaN I'm actually surprised the test isn't included in the PR, cause I did update it and I'm using JJ (which should include any unstaged changes with the revision). Weird

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.