PHPC-1627 Support object cloning for ReadConcern, ReadPreference, and WriteConcern#2002
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds safe object cloning support for MongoDB\Driver\ReadConcern, ReadPreference, and WriteConcern (PHPC-1627), along with regression tests.
Changes:
- Implement custom
clone_objhandlers to deep-copy the underlyingmongoc_*structs for ReadConcern/ReadPreference/WriteConcern. - Add PHPT tests validating clone equality/identity and clone survivability after unsetting the original.
- Bump the extension development version in
phongo_version.h.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/writeConcern/writeconcern-clone-001.phpt | New regression test asserting WriteConcern is cloneable and remains usable after the original is unset. |
| tests/readPreference/readpreference-clone-001.phpt | New regression test asserting ReadPreference cloning works with tag sets and max staleness options. |
| tests/readConcern/readconcern-clone-001.phpt | New regression test asserting ReadConcern is cloneable and remains usable after the original is unset. |
| src/MongoDB/WriteConcern.c | Add clone_obj handler using mongoc_write_concern_copy() to avoid pointer aliasing/double-free. |
| src/MongoDB/ReadPreference.c | Add clone_obj handler using mongoc_read_prefs_copy() to avoid pointer aliasing/double-free. |
| src/MongoDB/ReadConcern.c | Add clone_obj handler using mongoc_read_concern_copy() to avoid pointer aliasing/double-free. |
| phongo_version.h | Update extension dev version from 2.3.x-dev to 2.4.x-dev. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alcaeus
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHPC-1627