PHPLIB-1841: Support doesNotAffect arg for relevant operators#1927
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the doesNotAffect argument across selected Atlas Search operators in the PHP builder, and introduces facet documentation examples exercising the new argument in a $searchMeta facet pipeline.
Changes:
- Add
doesNotAffecttoequals,in,range, andcompoundsearch operators (plus factory methods), including list-shape validation for PHP arrays. - Add facet documentation examples (multi-select faceting + inter-facet filter exclusion) to pipeline fixtures and tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Builder/Search/Pipelines.php | Adds canonical Extended JSON pipeline fixtures for facet examples using doesNotAffect. |
| tests/Builder/Search/FacetOperatorTest.php | Adds PHPUnit coverage for the new facet examples that include doesNotAffect on equals. |
| src/Builder/Search/RangeOperator.php | Adds doesNotAffect property/constructor arg, encoding support, and list validation. |
| src/Builder/Search/InOperator.php | Adds doesNotAffect property/constructor arg, encoding support, and list validation. |
| src/Builder/Search/FactoryTrait.php | Extends factory methods (compound, equals, in, range) to accept/pass through doesNotAffect. |
| src/Builder/Search/EqualsOperator.php | Adds doesNotAffect property/constructor arg and encoding support with list validation. |
| src/Builder/Search/CompoundOperator.php | Adds doesNotAffect property/constructor arg and encoding support with list validation. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
GromNaN
reviewed
Jun 16, 2026
paulinevos
force-pushed
the
doesNotAffect
branch
from
5a29564 to
24cafdd
Compare
GromNaN
approved these changes
Jun 16, 2026
Also adds the examples from facet documentation (which shows only the `equals` operator with the new argument)
paulinevos
force-pushed
the
doesNotAffect
branch
from
24cafdd to
cf73dbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds the examples from facet documentation (which shows only the
equalsoperator with the new argument)Fixes PHPLIB-1841