Address review

Author: NoahStapp

gridfs/asynchronous/grid_file.py

@@ -1033,12 +1033,11 @@ async def rename_by_name(
           await fs.upload_from_stream("test_file", "data I want to store!")
           await fs.rename_by_name("test_file", "new_test_name")
 
-        Raises :exc:`~gridfs.errors.NoFile` if no file with file_id exists.
+        Raises :exc:`~gridfs.errors.NoFile` if no file with the given filename exists.
 
         :param filename: The filename of the file to be renamed.
         :param new_filename: The new name of the file.
-        :param session: a
-            :class:`~pymongo.client_session.AsyncClientSession`
+        :param session: a :class:`~pymongo.client_session.AsyncClientSession`
 
         .. versionadded:: 4.12
         """
@@ -1048,7 +1047,7 @@ async def rename_by_name(
         )
         if not result.matched_count:
             raise NoFile(
-                f"no files could be renamed {new_filename} because none matched filename {filename}"
+                f"no files could be renamed {new_filename!r} because none matched filename {filename!r}"
             )
 
 

gridfs/synchronous/grid_file.py

@@ -1027,12 +1027,11 @@ def rename_by_name(
           fs.upload_from_stream("test_file", "data I want to store!")
           fs.rename_by_name("test_file", "new_test_name")
 
-        Raises :exc:`~gridfs.errors.NoFile` if no file with file_id exists.
+        Raises :exc:`~gridfs.errors.NoFile` if no file with the given filename exists.
 
         :param filename: The filename of the file to be renamed.
         :param new_filename: The new name of the file.
-        :param session: a
-            :class:`~pymongo.client_session.ClientSession`
+        :param session: a :class:`~pymongo.client_session.ClientSession`
 
         .. versionadded:: 4.12
         """
@@ -1042,7 +1041,7 @@ def rename_by_name(
         )
         if not result.matched_count:
             raise NoFile(
-                f"no files could be renamed {new_filename} because none matched filename {filename}"
+                f"no files could be renamed {new_filename!r} because none matched filename {filename!r}"
             )
 
 

test/asynchronous/test_gridfs_bucket.py

@@ -439,6 +439,19 @@ async def test_rename(self):
             b"testing", await (await self.fs.open_download_stream_by_name("second_name")).read()
         )
 
+    async def test_rename_by_name(self):
+        _id = await self.fs.upload_from_stream("first_name", b"testing")
+        self.assertEqual(
+            b"testing", await (await self.fs.open_download_stream_by_name("first_name")).read()
+        )
+
+        await self.fs.rename_by_name("first_name", "second_name")
+        with self.assertRaises(NoFile):
+            await self.fs.open_download_stream_by_name("first_name")
+        self.assertEqual(
+            b"testing", await (await self.fs.open_download_stream_by_name("second_name")).read()
+        )
+
     @patch("gridfs.asynchronous.grid_file._UPLOAD_BUFFER_SIZE", 5)
     async def test_abort(self):
         gin = self.fs.open_upload_stream("test_filename", chunk_size_bytes=5)

test/asynchronous/unified_format.py

@@ -628,10 +628,7 @@ def process_error(self, exception, spec):
             # Connection errors are considered client errors.
             if isinstance(error, ConnectionFailure):
                 self.assertNotIsInstance(error, NotPrimaryError)
-            elif isinstance(error, (InvalidOperation, ConfigurationError, EncryptionError)):
-                pass
-            # gridfs NoFile errors are considered client errors.
-            elif isinstance(error, NoFile):
+            elif isinstance(error, (InvalidOperation, ConfigurationError, EncryptionError, NoFile)):
                 pass
             else:
                 self.assertNotIsInstance(error, PyMongoError)

test/test_gridfs_bucket.py

@@ -413,6 +413,15 @@ def test_rename(self):
             self.fs.open_download_stream_by_name("first_name")
         self.assertEqual(b"testing", (self.fs.open_download_stream_by_name("second_name")).read())
 
+    def test_rename_by_name(self):
+        _id = self.fs.upload_from_stream("first_name", b"testing")
+        self.assertEqual(b"testing", (self.fs.open_download_stream_by_name("first_name")).read())
+
+        self.fs.rename_by_name("first_name", "second_name")
+        with self.assertRaises(NoFile):
+            self.fs.open_download_stream_by_name("first_name")
+        self.assertEqual(b"testing", (self.fs.open_download_stream_by_name("second_name")).read())
+
     @patch("gridfs.synchronous.grid_file._UPLOAD_BUFFER_SIZE", 5)
     def test_abort(self):
         gin = self.fs.open_upload_stream("test_filename", chunk_size_bytes=5)

test/unified_format.py

@@ -627,10 +627,7 @@ def process_error(self, exception, spec):
             # Connection errors are considered client errors.
             if isinstance(error, ConnectionFailure):
                 self.assertNotIsInstance(error, NotPrimaryError)
-            elif isinstance(error, (InvalidOperation, ConfigurationError, EncryptionError)):
-                pass
-            # gridfs NoFile errors are considered client errors.
-            elif isinstance(error, NoFile):
+            elif isinstance(error, (InvalidOperation, ConfigurationError, EncryptionError, NoFile)):
                 pass
             else:
                 self.assertNotIsInstance(error, PyMongoError)