Copilot + Noah review

Author: aclark4life

test/asynchronous/test_periodic_executor.py

@@ -69,21 +69,6 @@ async def target():
         await executor.join(timeout=2)
         self.assertTrue(ran.is_set(), "target never ran")
 
-    async def test_target_exception_stops_executor(self):
-        call_count = 0
-
-        async def target():
-            nonlocal call_count
-            call_count += 1
-            raise RuntimeError("error")
-
-        executor = self._make_executor(target=target)
-        executor.open()
-        await executor.join(timeout=2)
-        if executor._task is not None and executor._task.done():
-            executor._task.exception()
-        self.assertEqual(call_count, 1, "target should stop after exception")
-
     async def test_skip_sleep_flag_skips_interval(self):
         call_times = []
 

test/test_periodic_executor.py

@@ -23,14 +23,14 @@
 
 sys.path[0:0] = [""]
 
-from test import UnitTest, unittest
+from test.synchronous import UnitTest, unittest
 
 from pymongo.periodic_executor import PeriodicExecutor
 
-_IS_SYNC = True
+_IS_SYNC = False
 
 
-class TestPeriodicExecutor(UnitTest):
+class TestAsyncPeriodicExecutor(UnitTest):
     def _make_executor(self, interval=30.0, min_interval=0.01, target=None, name="test"):
         if target is None:
 
@@ -69,21 +69,6 @@ def target():
         executor.join(timeout=2)
         self.assertTrue(ran.is_set(), "target never ran")
 
-    def test_target_exception_stops_executor(self):
-        call_count = 0
-
-        def target():
-            nonlocal call_count
-            call_count += 1
-            raise RuntimeError("error")
-
-        executor = self._make_executor(target=target)
-        executor.open()
-        executor.join(timeout=2)
-        if executor._task is not None and executor._task.done():
-            executor._task.exception()
-        self.assertEqual(call_count, 1, "target should stop after exception")
-
     def test_skip_sleep_flag_skips_interval(self):
         call_times = []
 

tools/synchro.py

@@ -190,6 +190,7 @@ def async_only_test(f: str) -> bool:
         "test_async_loop_safety.py",
         "test_async_contextvars_reset.py",
         "test_async_loop_unblocked.py",
+        "test_async_periodic_executor.py",
     ]
 
 
@@ -252,7 +253,6 @@ def async_only_test(f: str) -> bool:
     "test_monitoring.py",
     "test_mongos_load_balancing.py",
     "test_on_demand_csfle.py",
-    "test_periodic_executor.py",
     "test_pooling.py",
     "test_raw_bson.py",
     "test_read_concern.py",