Copilot review

Author: aclark4life

test/test_message.py

@@ -24,7 +24,7 @@
 
 from test import unittest
 
-from bson import CodecOptions
+from bson import CodecOptions, encode
 from pymongo.compression_support import ZlibContext
 from pymongo.errors import DocumentTooLarge, OperationFailure
 from pymongo.message import (
@@ -179,10 +179,11 @@ def test_max_doc_size_zero_without_docs(self):
         _, _, _, max_doc_size = _op_msg(0, {"ping": 1}, "testdb", None, _OPTS)
         self.assertEqual(max_doc_size, 0)
 
-    def test_max_doc_size_nonzero_with_docs(self):
-        cmd: dict = {"insert": "col", "documents": [{"_id": 1, "x": 2}, {"_id": 3, "x": 4}]}
+    def test_max_doc_size_matches_largest_encoded_doc(self):
+        docs = [{"_id": 1, "x": 2}, {"_id": 3, "x": 4}]
+        cmd: dict = {"insert": "col", "documents": docs}
         _, _, _, max_doc_size = _op_msg(0, cmd, "testdb", None, _OPTS)
-        self.assertGreater(max_doc_size, 0)
+        self.assertEqual(max_doc_size, max(len(encode(d)) for d in docs))
 
     def test_read_preference_added_for_non_primary(self):
         cmd: dict = {"find": "col"}
@@ -208,10 +209,6 @@ def test_command_with_documents_field_is_restored(self):
 
 
 class TestQuery(unittest.TestCase):
-    def test_basic(self):
-        _, max_bson_size = _query_impl(0, "db.col", 0, 0, {"x": 1}, None, _OPTS)
-        self.assertGreater(max_bson_size, 0)
-
     def test_uncompressed_op_code(self):
         _rid, msg, _mbs = _query_uncompressed(0, "db.col", 0, 0, {}, None, _OPTS)
         op_code = struct.unpack("<i", msg[12:16])[0]
@@ -257,7 +254,7 @@ def test_basic(self):
 
     def test_with_projection(self):
         cmd = _gen_find_command("col", {}, {"x": 1}, 0, 0, None, None, ReadConcern())
-        self.assertIn("projection", cmd)
+        self.assertEqual(cmd["projection"], {"x": 1})
 
     def test_with_skip(self):
         cmd = _gen_find_command("col", {}, None, 5, 0, None, None, ReadConcern())
@@ -284,7 +281,7 @@ def test_batch_size_not_adjusted_when_different(self):
 
     def test_read_concern_level_included(self):
         cmd = _gen_find_command("col", {}, None, 0, 0, None, None, ReadConcern("majority"))
-        self.assertIn("readConcern", cmd)
+        self.assertEqual(cmd["readConcern"], {"level": "majority"})
 
     def test_query_with_dollar_query_modifier(self):
         spec = {"$query": {"x": 1}, "$orderby": {"x": 1}}