Skip to content

Commit d2617b1

Browse files
committed
Address PR feedback: update CONTRIBUTING.md, only set UV_EXCLUDE_NEWER if unset
1 parent 34b5d19 commit d2617b1

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

.evergreen/combine-coverage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ set -eu
88
# Set up the virtual env.
99
. .evergreen/scripts/setup-dev-env.sh
1010
export UV_NO_LOCK=1
11-
export UV_EXCLUDE_NEWER=$(python3 -c "from datetime import datetime, timedelta, timezone; print((datetime.now(timezone.utc) - timedelta(days=7)).strftime('%Y-%m-%dT%H:%M:%SZ'))")
11+
export UV_EXCLUDE_NEWER="${UV_EXCLUDE_NEWER:-$(python3 -c "from datetime import datetime, timedelta, timezone; print((datetime.now(timezone.utc) - timedelta(days=7)).strftime('%Y-%m-%dT%H:%M:%SZ'))")}"
1212
uv sync --group coverage
1313
source .venv/bin/activate
1414

.evergreen/scripts/setup_tests.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,11 @@ def handle_test_env() -> None:
171171
write_env("PIP_QUIET") # Quiet by default.
172172
write_env("PIP_PREFER_BINARY") # Prefer binary dists by default.
173173
write_env("UV_NO_LOCK", "1")
174-
exclude_newer = (datetime.now(timezone.utc) - timedelta(days=7)).strftime("%Y-%m-%dT%H:%M:%SZ")
175-
write_env("UV_EXCLUDE_NEWER", exclude_newer)
174+
if not os.environ.get("UV_EXCLUDE_NEWER"):
175+
exclude_newer = (datetime.now(timezone.utc) - timedelta(days=7)).strftime(
176+
"%Y-%m-%dT%H:%M:%SZ"
177+
)
178+
write_env("UV_EXCLUDE_NEWER", exclude_newer)
176179

177180
# Set an environment variable for the test name and sub test name.
178181
write_env(f"TEST_{test_name.upper()}")

CONTRIBUTING.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,5 @@ From the spawn host or Ubuntu image, do the following:
574574
## Dependabot updates
575575

576576
Dependabot will raise PRs at most once per week, grouped by GitHub Actions updates and Python requirement
577-
file updates. We have a pre-commit hook that will update the `uv.lock` file when requirements change.
578-
To update the lock file on a failing PR, you can use a method like `gh pr checkout <pr number>`, then run
579-
`just lint uv-lock` to update the lock file, and then push the changes. If a typing dependency has changed,
580-
also run `just typing` and handle any new findings.
577+
file updates. To handle a failing Dependabot PR, you can use a method like `gh pr checkout <pr number>`,
578+
then push the changes. If a typing dependency has changed, also run `just typing` and handle any new findings.

0 commit comments

Comments
 (0)