Skip to content

PYTHON-5890 Remove automatic synchro for local testing#2890

Merged
blink1073 merged 1 commit into
mongodb:masterfrom
blink1073:PYTHON-5890-remove-test-sync
Jun 23, 2026
Merged

PYTHON-5890 Remove automatic synchro for local testing#2890
blink1073 merged 1 commit into
mongodb:masterfrom
blink1073:PYTHON-5890-remove-test-sync

Conversation

@blink1073

@blink1073 blink1073 commented Jun 23, 2026

Copy link
Copy Markdown
Member

PYTHON-5890

Changes in this PR

Removes the run-synchro recipe from the justfile (introduced in #2887) and its use as a pre-dependency on just test and just run-tests. When invoked this way, synchro runs on all async files unconditionally — if any of those files have linting issues or are in a partially-edited state, the run fails before tests even start. Synchro already runs automatically via the pre-commit hook on commit, scoped to only the files being staged.

Test Plan

CI passes. Locally, just test and just run-tests no longer trigger synchro.

Checklist

Checklist for Author

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@blink1073 blink1073 requested a review from a team as a code owner June 23, 2026 00:43
@blink1073 blink1073 requested a review from NoahStapp June 23, 2026 00:43
@blink1073

Copy link
Copy Markdown
Member Author

@blink1073 blink1073 changed the title PYTHON-5890 Remove synchro pre-dep from just test and run-tests PYTHON-5890 Remove automatic synchro for local testing Jun 23, 2026
@blink1073 blink1073 requested review from sleepyStick and removed request for NoahStapp June 23, 2026 00:54
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@blink1073 blink1073 merged commit 1dd0747 into mongodb:master Jun 23, 2026
83 of 88 checks passed
@blink1073 blink1073 deleted the PYTHON-5890-remove-test-sync branch June 23, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants