Skip to content

Commit 0042e29

Browse files
Fix rubocop offenses in spec: use Kernel.sleep stub, compact test
1 parent 81fac05 commit 0042e29

1 file changed

Lines changed: 5 additions & 10 deletions

File tree

spec/mongo/session/with_transaction_timeout_spec.rb

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
allow(session).to receive(:commit_transaction) do
4444
session.instance_variable_set(:@state, Mongo::Session::TRANSACTION_COMMITTED_STATE)
4545
end
46-
allow_any_instance_of(Mongo::Session::WithTransactionRunner).to receive(:sleep)
46+
allow(Kernel).to receive(:sleep)
4747
end
4848

4949
# Stubs Mongo::Utils.monotonic_time: first `initial_calls` invocations
@@ -234,19 +234,14 @@ def make_commit_overload_error
234234

235235
it 'retries and succeeds (does not raise TimeoutError)' do
236236
allow(Mongo::Utils).to receive(:monotonic_time).and_return(0.0)
237-
238-
call_count = 0
237+
calls = 0
239238
allow(session).to receive(:commit_transaction) do
240-
call_count += 1
241-
raise commit_error if call_count == 1
239+
calls += 1
240+
raise commit_error if calls == 1
242241

243242
session.instance_variable_set(:@state, Mongo::Session::TRANSACTION_COMMITTED_STATE)
244243
end
245-
246-
result = session.with_transaction(timeout_ms: 0) do
247-
session.instance_variable_set(:@state, Mongo::Session::TRANSACTION_IN_PROGRESS_STATE)
248-
success_return_value
249-
end
244+
result = session.with_transaction(timeout_ms: 0) { success_return_value }
250245
expect(result).to eq(success_return_value)
251246
end
252247
end

0 commit comments

Comments
 (0)