RUBY-3794 Fix rubocop offenses from removed record_success calls

Author: comandeo-mongo

lib/mongo/retryable/read_worker.rb

@@ -200,9 +200,7 @@ def modern_read_with_retry(session, server_selector, context, &block)
           session,
           timeout: context&.remaining_timeout_sec
         )
-        result = yield server
-
-        result
+        yield server
       rescue *retryable_exceptions, Error::OperationFailure::Family, Auth::Unauthorized, Error::PoolError => e
         e.add_notes('modern retry', 'attempt 1')
         raise e if session.in_transaction? && !retryable_overload_error?(e)
@@ -295,8 +293,7 @@ def retry_read(original_error, session, server_selector, context: nil, failed_se
         begin
           context&.check_timeout!
           attempt = attempt ? attempt + 1 : 2
-          result = yield server, true
-          result
+          yield server, true
         rescue Error::TimeoutError
           raise
         rescue *retryable_exceptions => e

lib/mongo/retryable/write_worker.rb

@@ -111,10 +111,9 @@ def nro_write_with_retry(_write_concern, context:, &block)
           error_count = 0
           error_to_raise = nil
           begin
-            result = server.with_connection(connection_global_id: context.connection_global_id) do |connection|
+            server.with_connection(connection_global_id: context.connection_global_id) do |connection|
               yield connection, nil, context
             end
-            result
           rescue Error::TimeoutError
             raise
           rescue *retryable_exceptions, Error::PoolError, Error::OperationFailure::Family => e
@@ -253,7 +252,7 @@ def modern_write_with_retry(session, server, context, &block)
         connection_succeeded = false
         was_starting = false
 
-        result = server.with_connection(
+        server.with_connection(
           connection_global_id: context.connection_global_id,
           context: context
         ) do |connection|
@@ -267,8 +266,6 @@ def modern_write_with_retry(session, server, context, &block)
           # it later for the retry as well.
           yield connection, txn_num, context.dup
         end
-
-        result
       rescue *retryable_exceptions, Error::PoolError, Auth::Unauthorized, Error::OperationFailure::Family => e
         e.add_notes('modern retry', 'attempt 1')
 
@@ -343,10 +340,9 @@ def retry_write(original_error, txn_num, context:, failed_server: nil, &block)
 
         attempt = attempt ? attempt + 1 : 2
         log_retry(original_error, message: 'Write retry')
-        result = server.with_connection(connection_global_id: context.connection_global_id) do |connection|
+        server.with_connection(connection_global_id: context.connection_global_id) do |connection|
           yield(connection, txn_num, context)
         end
-        result
       rescue *retryable_exceptions, Error::PoolError => e
         if retryable_overload_error?(e)
           e.add_notes('modern retry', "attempt #{attempt}")

lib/mongo/session.rb

@@ -461,7 +461,7 @@ def with_transaction(options = nil)
       overload_error_count = 0
       overload_encountered = false
 
-      loop do # rubocop:disable Metrics/BlockLength
+      loop do
         if transaction_attempt > 0
           if overload_encountered
             delay = @client.retry_policy.backoff_delay(overload_error_count)