Skip to content

Commit 8db6431

Browse files
authored
Enable rubocop on all files, with exceptions (#3005)
* Enable rubocop on all files * Add a rubocop:install_hook task to make it easier to add the pre-commit hook * use the same checkout task version as the test task This is to try and figure out why the rubocop task is checking out the wrong SHA * fix rubocop complaints with sdam_prose_spec * make rubocop only lint the current branch (not a merge with master) * trying to get rubocop to run in PR's again... * ugh, issue is the `ref` being in the wrong place * maybe the pull_request trigger is necessary after all... * fix rubocop autocorrect failure
1 parent 40ce1b6 commit 8db6431

File tree

883 files changed

+18482
-22811
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

883 files changed

+18482
-22811
lines changed

.github/workflows/rubocop.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
---
21
name: Rubocop
3-
4-
on: [push, pull_request]
2+
on: [ push, pull_request ]
53

64
jobs:
75
build:
@@ -10,7 +8,10 @@ jobs:
108
CI: true
119
TESTOPTS: "-v"
1210
steps:
13-
- uses: actions/checkout@v3
11+
- uses: actions/checkout@v2
12+
with:
13+
ref: ${{ github.event.pull_request.head.sha || github.sha }}
14+
submodules: recursive
1415
- name: Set up Ruby 3.0
1516
uses: ruby/setup-ruby@v1
1617
with:

.rubocop.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
inherit_from: .rubocop_todo.yml
2+
inherit_mode:
3+
merge:
4+
- Exclude
5+
16
plugins:
27
- rubocop-performance
38
- rubocop-rake

0 commit comments

Comments
 (0)