RUBY-3733 update rubocop (#3002)

* RUBY-3733 update rubocop

* upload-api-docs snuck under the radar

Author: jamis

.rubocop.yml

@@ -1,10 +1,10 @@
-require:
+plugins:
   - rubocop-performance
   - rubocop-rake
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.7
   NewCops: enable
   Exclude:
     - 'spec/shared/**/*'
@@ -51,6 +51,9 @@ Layout/SpaceInsideArrayLiteralBrackets:
 Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false
 
+Lint/UselessConstantScoping:
+  Enabled: false
+
 Metrics/ClassLength:
   Max: 200
 
@@ -63,6 +66,9 @@ Metrics/MethodLength:
 Naming/MethodParameterName:
   AllowedNames: [ id, op ]
 
+Naming/PredicateMethod:
+  Enabled: false
+
 RSpec/BeforeAfterAll:
   Enabled: false
 
@@ -71,12 +77,24 @@ RSpec/BeforeAfterAll:
 RSpec/DescribeClass:
   Enabled: false
 
+RSpec/Eq:
+  Enabled: false
+
 Style/FetchEnvVar:
   Enabled: false
 
 RSpec/ImplicitExpect:
   EnforcedStyle: is_expected
 
+RSpec/IncludeExamples:
+  Enabled: false
+
+RSpec/IndexedLet:
+  Enabled: false
+
+RSpec/ExpectInLet:
+  Enabled: false
+
 RSpec/MultipleExpectations:
   Enabled: false
 
@@ -86,6 +104,9 @@ RSpec/MultipleMemoizedHelpers:
 RSpec/NestedGroups:
   Enabled: false
 
+RSpec/ReceiveMessages:
+  Enabled: false
+
 Style/Documentation:
   Exclude:
     - 'spec/**/*'

gemfiles/standard.rb

@@ -29,10 +29,10 @@ def standard_dependencies
     gem 'yajl-ruby', platforms: :mri, require: false
     gem 'celluloid', platforms: :mri, require: false
 
-    gem 'rubocop', '~> 1.45.1'
-    gem 'rubocop-performance', '~> 1.16.0'
-    gem 'rubocop-rake', '~> 0.6.0'
-    gem 'rubocop-rspec', '~> 2.18.1'
+    gem 'rubocop', '~> 1.85.1'
+    gem 'rubocop-performance', '~> 1.26.1'
+    gem 'rubocop-rake', '~> 0.7.1'
+    gem 'rubocop-rspec', '~> 3.9.0'
 
     platform :mri do
       # Debugger for VSCode.

…ion/retryable_writes/retryable_writes.rb …etryable_writes/retryable_writes_spec.rbspec/integration/retryable_writes/retryable_writes.rb renamed to spec/integration/retryable_writes/retryable_writes_spec.rb spec/integration/retryable_writes/retryable_writes.rb renamed to spec/integration/retryable_writes/retryable_writes_spec.rb

@@ -70,7 +70,6 @@
             # Client is created here.
             client
           end
-          puts "client_construction_spec.rb: Cluster is: #{client.cluster.summary}"
 
           # Because the first round of sdam waits for server statuses to change
           # rather than for server selection semaphore on the cluster which
@@ -2604,13 +2603,6 @@
 
         new_client.cluster.next_primary
 
-        # Diagnostics
-        # rubocop:disable Style/IfUnlessModifier, Lint/Debugger
-        unless subscriber.started_events.empty?
-          p subscriber.started_events
-        end
-        # rubocop:enable Style/IfUnlessModifier, Lint/Debugger
-
         expect(subscriber.started_events.length).to eq 0
         expect(new_client.cluster.topology.class).not_to be Mongo::Cluster::Topology::Unknown
       end

spec/mongo/client_construction_spec.rb

@@ -17,7 +17,7 @@
     it 'closes all pipes and removes them from the map' do
       expect(manager.pipe_fds(service_id: service_id).size).to eq(2)
 
-      manager.instance_variable_get(:@pipe_fds)[service_id].each do |_gen, (r, w)|
+      manager.instance_variable_get(:@pipe_fds)[service_id].each_value do |(r, w)|
         expect(r).to receive(:close).and_call_original
         expect(w).to receive(:close).and_call_original
       end

spec/mongo/server/connection_pool/generation_manager_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Tracing
-  Error = Class.new(StandardError)
+  class Error < StandardError; end
 
   class Span
     attr_reader :tracer, :name, :attributes, :with_parent, :kind, :finished, :nested

spec/support/tracing.rb

@@ -6,7 +6,10 @@ module Net
   autoload :HTTP, 'net/http'
 end
 
+# rubocop:disable Style/OneClassPerFile
 module Utils
+  # rubocop:enable Style/OneClassPerFile
+
   extend self
 
   # Used by #yamlify_command_events
@@ -212,7 +215,7 @@ def yamlify_command_events(events)
   # rubocop:disable Metrics
   def convert_operation_options(options)
     if options
-      options.map do |k, v|
+      options.filter_map do |k, v|
         out_v =
           case k
           when 'readPreference'
@@ -242,7 +245,7 @@ def convert_operation_options(options)
             # they mean is for the driver to use the default write concern,
             # which for Ruby means no write concern is specified at all.
             #
-            # This nil return requires the compact call below to get rid of
+            # This nil return requires the filter_map call above to get rid of
             # the nils before outgoing options are constructed.
             next nil if v == {}
 
@@ -255,7 +258,7 @@ def convert_operation_options(options)
             raise "Unhandled operation option #{k}"
           end
         [ out_k, out_v ]
-      end.compact.to_h
+      end.to_h
     else
       {}
     end
@@ -429,11 +432,11 @@ def wait_for_instance_profile
       begin
         ip = ec2_instance_profile
         if ip
-          puts "Instance profile assigned: #{ip}"
+          warn "Instance profile assigned: #{ip}"
           break
         end
       rescue StandardError => e
-        puts "Problem retrieving instance profile: #{e.class}: #{e}"
+        warn "Problem retrieving instance profile: #{e.class}: #{e}"
       end
 
       if Process.clock_gettime(Process::CLOCK_MONOTONIC) >= deadline
@@ -450,11 +453,11 @@ def wait_for_no_instance_profile
       begin
         ip = ec2_instance_profile
         if ip.nil?
-          puts 'Instance profile cleared'
+          warn 'Instance profile cleared'
           break
         end
       rescue StandardError => e
-        puts "Problem retrieving instance profile: #{e.class}: #{e}"
+        warn "Problem retrieving instance profile: #{e.class}: #{e}"
       end
 
       if Process.clock_gettime(Process::CLOCK_MONOTONIC) >= deadline

spec/support/utils.rb

@@ -1,6 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
+# rubocop:disable Style/OneClassPerFile
+
 require 'bundler/inline'
 
 gemfile true do
@@ -125,3 +127,5 @@ options = Options.new
 generate_docs(options)
 FileUploader.new(options).upload_docs
 return
+
+# rubocop:enable Style/OneClassPerFile