Skip to content

RUBY-3714 Client metadata capture for TruffleRuby #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleburgess2025 merged 8 commits into from
Dec 9, 2025
Merged

RUBY-3714 Client metadata capture for TruffleRuby #2971

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8f46d9a
Including ruby engine in metadata in logs
kyleburgess2025 Dec 8, 2025
a1b6fe0
updating comment
kyleburgess2025 Dec 8, 2025
99bca35
changing capitalization of tests to work with new changes
kyleburgess2025 Dec 8, 2025
119f370
Readding jruby?
kyleburgess2025 Dec 8, 2025
8b796dc
Making tests work with capitalization of Ruby
kyleburgess2025 Dec 8, 2025
13259de
Fixing capitalization for engines
kyleburgess2025 Dec 9, 2025
f505430
Responding to PR comments
kyleburgess2025 Dec 9, 2025
d6cc4e6
Fixing some typos
kyleburgess2025 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/mongo/server/app_metadata/platform.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ def initialize(metadata)
@metadata = metadata
end

# Queries whether the current runtime is JRuby or not.
# Queries whether the current runtime is Ruby or not.
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is unclear. Since this method is always called within a Ruby runtime, it should clarify that it checks for standard Ruby/MRI specifically, not whether Ruby is running. Consider: 'Queries whether the current runtime is standard Ruby (MRI).'

Copilot uses AI. Check for mistakes.
#
# @return [ true | false ] whether the runtime is JRuby or not.
def jruby?
BSON::Environment.jruby?
# @return [ Boolean ] whether the current runtime is Ruby
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value documentation is incomplete and unclear. It should specify 'whether the current runtime is standard Ruby (MRI)' to distinguish from other Ruby implementations.

Copilot uses AI. Check for mistakes.
def ruby?
Copy link
Copy Markdown
Contributor

@jamis jamis Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"mri" ("matz's ruby implementation") is how the canonical implementation is usually called. It might be better to name this predicate mri? to reflect that, since ruby? is probably overly broad.

Suggested change
def ruby?
def mri?

Copy link
Copy Markdown
Contributor Author

@kyleburgess2025 kyleburgess2025 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

RUBY_ENGINE == 'ruby'
end

# Returns the list of Ruby versions that identify this runtime.
#
# @return [ Array<String> ] the list of ruby versions
def ruby_versions
if jruby?
[ "JRuby #{JRUBY_VERSION}", "like Ruby #{RUBY_VERSION}" ]
else
if ruby?
[ "Ruby #{RUBY_VERSION}" ]
else
[ "#{RUBY_ENGINE} #{RUBY_ENGINE_VERSION}", "like Ruby #{RUBY_VERSION}" ]
end
end

Expand Down
Loading