RUBY-3742 Fix backpressure tests#2994
Merged
comandeo-mongo merged 3 commits intomongodb:masterfrom Mar 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Ruby driver’s SDAM/backpressure test suite to reduce flakiness and expand coverage for connection pool backpressure behaviors, and adjusts Evergreen variants to run relevant suites against MongoDB “rapid”.
Changes:
- Add/adjust SDAM unified spec tests around
minPoolSizepopulation failures and pool clearing behavior. - Stabilize concurrency-related unit tests (token bucket) and tweak integration test expectations.
- Expand Evergreen matrices (CSOT and FLE) to include the
rapidMongoDB version.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
spec/spec_tests/data/sdam_unified/pool-clear-min-pool-size-error.yml |
Adds unified SDAM coverage for pool clear vs. non-clear during minPoolSize population errors. |
spec/spec_tests/data/sdam_unified/minPoolSize-error.yml |
Adjusts minPoolSize failure test to use a server error and polling monitor mode. |
spec/mongo/retryable/token_bucket_spec.rb |
Makes the thread-safety assertion deterministic by avoiding floor/ceiling effects. |
spec/integration/secondary_reads_spec.rb |
Relaxes tolerance on read-counter assertions (risk: can weaken regression detection). |
spec/integration/sdam_prose_spec.rb |
Adds an integration spec for connection pool backpressure via server ingress rate limiter parameters. |
.evergreen/config/standard.yml.erb / .evergreen/config.yml |
Adds rapid to CSOT and FLE buildvariant MongoDB version matrices. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
comandeo-mongo
force-pushed
the
3742-fix-backpressure-tests
branch
from
5f56079 to
3166677
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Mongo::Error::PoolTimeout does not exist; replace with StandardError which covers all connection-related errors (SocketError, pool checkout timeouts, NoServerAvailable, etc.).
jamis
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.