Skip to content

RUBY-3733 update rubocop#3002

Merged
jamis merged 2 commits intomongodb:masterfrom
jamis:20260320-rubocop-work
Mar 23, 2026
Merged

RUBY-3733 update rubocop#3002
jamis merged 2 commits intomongodb:masterfrom
jamis:20260320-rubocop-work

Conversation

@jamis
Copy link
Copy Markdown
Contributor

@jamis jamis commented Mar 20, 2026

The version of Rubocop we've been using emits a large number of deprecation warnings because of the parser it uses. This PR bumps to the most recent version of Rubocop and updates the .rubocop.yml to ensure that any new cops are ignored (for now).

Copilot AI review requested due to automatic review settings March 20, 2026 15:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates RuboCop to a newer version to eliminate parser deprecation warnings, and adjusts code/config to satisfy updated lint rules across specs and support helpers.

Changes:

  • Bump RuboCop + related extension gems to newer versions.
  • Update .rubocop.yml (plugin loading, Ruby target version, and disabling newly-triggered cops).
  • Apply small style-driven refactors in specs/support code (e.g., filter_map, warn, class definition style) and add a new retryable writes integration spec.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gemfiles/standard.rb Updates RuboCop and related lint gem versions.
.rubocop.yml Switches to plugins: syntax, targets Ruby 2.7, and disables additional cops.
spec/support/utils.rb Refactors option conversion to filter_map, adjusts rubocop directives, and routes diagnostic output to warn.
spec/support/tracing.rb Adjusts error class definition style.
spec/mongo/server/connection_pool/generation_manager_spec.rb Simplifies hash iteration in a spec.
spec/mongo/client_construction_spec.rb Removes debug/diagnostic output from specs.
spec/integration/retryable_writes/retryable_writes_spec.rb Adds integration coverage for retryable writes behavior using shared examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamis jamis requested a review from a team as a code owner March 20, 2026 15:11
@jamis jamis requested a review from comandeo-mongo March 20, 2026 15:11
@jamis jamis merged commit f171ec7 into mongodb:master Mar 23, 2026
172 of 175 checks passed
@jamis jamis deleted the 20260320-rubocop-work branch March 23, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants