Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates RuboCop to a newer version to eliminate parser deprecation warnings, and adjusts code/config to satisfy updated lint rules across specs and support helpers.
Changes:
- Bump RuboCop + related extension gems to newer versions.
- Update
.rubocop.yml(plugin loading, Ruby target version, and disabling newly-triggered cops). - Apply small style-driven refactors in specs/support code (e.g.,
filter_map,warn, class definition style) and add a new retryable writes integration spec.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
gemfiles/standard.rb |
Updates RuboCop and related lint gem versions. |
.rubocop.yml |
Switches to plugins: syntax, targets Ruby 2.7, and disables additional cops. |
spec/support/utils.rb |
Refactors option conversion to filter_map, adjusts rubocop directives, and routes diagnostic output to warn. |
spec/support/tracing.rb |
Adjusts error class definition style. |
spec/mongo/server/connection_pool/generation_manager_spec.rb |
Simplifies hash iteration in a spec. |
spec/mongo/client_construction_spec.rb |
Removes debug/diagnostic output from specs. |
spec/integration/retryable_writes/retryable_writes_spec.rb |
Adds integration coverage for retryable writes behavior using shared examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
comandeo-mongo
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of Rubocop we've been using emits a large number of deprecation warnings because of the parser it uses. This PR bumps to the most recent version of Rubocop and updates the .rubocop.yml to ensure that any new cops are ignored (for now).