Enable rubocop on all files, with exceptions#3005
Merged
jamis merged 10 commits intomongodb:masterfrom Mar 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables RuboCop across the codebase by removing per-file # rubocop:todo all opt-outs and centralizing lint exceptions in .rubocop_todo.yml, while also applying RuboCop autocorrections (quoting, formatting, small refactors) and adding a Rake task to run RuboCop.
Changes:
- Remove widespread
# rubocop:todo allfile-level opt-outs and rely on.rubocop_todo.ymlvia.rubocop.yml. - Apply safe autocorrections across
lib/,examples/,gemfiles/and related files. - Add
rake rubocoptask + optional Git hook installer inRakefile.
Reviewed changes
Copilot reviewed 299 out of 882 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/mongo/operation/drop.rb | Remove RuboCop opt-out comment / whitespace normalization. |
| lib/mongo/operation/distinct/op_msg.rb | Remove opt-out; minor selector cleanup (unused param, trailing comma). |
| lib/mongo/operation/distinct.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/delete/result.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/operation/delete/op_msg.rb | Remove opt-out; selector arg rename + formatting changes. |
| lib/mongo/operation/delete/bulk_result.rb | Remove opt-out; small refactor inside reduction. |
| lib/mongo/operation/delete.rb | Remove opt-out; simplify constant literal. |
| lib/mongo/operation/create_user/op_msg.rb | Remove opt-out; keyword key style + unused param. |
| lib/mongo/operation/create_user.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/create_index/op_msg.rb | Remove opt-out; simplify commitQuorum guard. |
| lib/mongo/operation/create_index.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/create/op_msg.rb | Remove opt-out; unused param + trailing comma removal. |
| lib/mongo/operation/create.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/count/op_msg.rb | Remove opt-out; unused param + trailing comma removal. |
| lib/mongo/operation/count.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/context.rb | Remove opt-out; simplify validation/attr_readers/guards. |
| lib/mongo/operation/command/op_msg.rb | Remove opt-out; unused param rename. |
| lib/mongo/operation/command.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/collections_info/result.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/collections_info.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/aggregate/result.rb | Remove opt-out; simplify constants. |
| lib/mongo/operation/aggregate/op_msg.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation/aggregate.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/operation.rb | Remove opt-out; remove duplicate require; simplify constants. |
| lib/mongo/monitoring/unified_sdam_log_subscriber.rb | Remove opt-out; modernize alias syntax. |
| lib/mongo/monitoring/topology_opening_log_subscriber.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/topology_closed_log_subscriber.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/topology_changed_log_subscriber.rb | Remove opt-out; refactor conditional + string formatting. |
| lib/mongo/monitoring/server_opening_log_subscriber.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/server_description_changed_log_subscriber.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/server_closed_log_subscriber.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/sdam_log_subscriber.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/topology_opening.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/topology_closed.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/topology_changed.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/server_opening.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/server_heartbeat_succeeded.rb | Remove opt-out; signature formatting + alias syntax. |
| lib/mongo/monitoring/event/server_heartbeat_started.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/server_heartbeat_failed.rb | Remove opt-out; signature formatting + alias syntax. |
| lib/mongo/monitoring/event/server_description_changed.rb | Remove opt-out; formatting + TODO punctuation. |
| lib/mongo/monitoring/event/server_closed.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/secure.rb | Remove opt-out; use %w[], simplify branches. |
| lib/mongo/monitoring/event/command_succeeded.rb | Remove opt-out; signature formatting + conditional simplification. |
| lib/mongo/monitoring/event/command_started.rb | Remove opt-out; signature formatting + small block var cleanup. |
| lib/mongo/monitoring/event/command_failed.rb | Remove opt-out; signature formatting. |
| lib/mongo/monitoring/event/cmap/pool_ready.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/pool_created.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/pool_closed.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/pool_cleared.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/connection_ready.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/connection_created.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/connection_closed.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/connection_checked_out.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/connection_checked_in.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/connection_check_out_started.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/connection_check_out_failed.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/event/cmap/base.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/monitoring/command_log_subscriber.rb | Remove opt-out; simplify debug guards and formatting. |
| lib/mongo/monitoring/cmap_log_subscriber.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/logger.rb | Remove opt-out; replace trivial writer method with attr_writer. |
| lib/mongo/loggable.rb | Remove opt-out; simplify logger selection + string formatting. |
| lib/mongo/index.rb | Remove opt-out; simplify constant literals. |
| lib/mongo/id.rb | Remove opt-out comment. |
| lib/mongo/grid/stream/write.rb | Remove opt-out; hash key style; comment block conversion. |
| lib/mongo/grid/stream/read.rb | Remove opt-out; refactors in iteration + validation methods. |
| lib/mongo/grid/stream.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/grid/file/chunk.rb | Remove opt-out; simplify constants; hash key style; unused param rename. |
| lib/mongo/grid/file.rb | Remove opt-out; simplify chunk init + hash key style. |
| lib/mongo/event/subscriber.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/event/publisher.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/event/listeners.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/event/base.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/event.rb | Remove opt-out; simplify constant literals. |
| lib/mongo/error/write_retryable.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/unsupported_option.rb | Remove opt-out; standardize quoting/wrapping for messages. |
| lib/mongo/error/unsupported_message_type.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/unsupported_features.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/unsupported_collation.rb | Remove opt-out; standardize quoting/wrapping. |
| lib/mongo/error/unsupported_array_filters.rb | Remove opt-out; standardize quoting/wrapping. |
| lib/mongo/error/unmet_dependency.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/unknown_payload_type.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/unexpected_response.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/unexpected_chunk_length.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/unchangeable_collection_option.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/socket_timeout_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/socket_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/snapshot_session_transaction_prohibited.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/snapshot_session_invalid_server_version.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/sessions_not_supported.rb | Remove opt-out; simplify super call. |
| lib/mongo/error/session_not_materialized.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/session_ended.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/server_not_usable.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/server_certificate_revoked.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/server_api_conflict.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/sdam_error_detection.rb | Remove opt-out; numeric readability with underscores. |
| lib/mongo/error/read_write_retryable.rb | Remove opt-out; hash literal + numeric formatting; paren clarity. |
| lib/mongo/error/raise_original_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/pool_paused_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/pool_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/pool_closed_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/pool_cleared_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/operation_failure.rb | Remove opt-out; numeric readability; small logic refactors. |
| lib/mongo/error/notable.rb | Remove opt-out; simplify note handling logic. |
| lib/mongo/error/no_srv_records.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/no_service_connection_available.rb | Remove opt-out; trailing comma removal. |
| lib/mongo/error/no_server_available.rb | Remove opt-out; simplify message construction. |
| lib/mongo/error/need_primary_server.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/multi_index_drop.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/mongocryptd_spawn_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/missing_service_id.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/missing_scram_server_signature.rb | Remove opt-out; simplify super usage. |
| lib/mongo/error/missing_resume_token.rb | Remove opt-out; simplify constant literal. |
| lib/mongo/error/missing_password.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/missing_file_chunk.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/missing_connection.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/mismatched_domain.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/max_message_size.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/max_bson_size.rb | Remove opt-out; simplify message selection logic. |
| lib/mongo/error/lint_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/labelable.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/kms_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_write_concern.rb | Remove opt-out; string wrapping/quoting changes. |
| lib/mongo/error/invalid_uri.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_update_document.rb | Remove opt-out; standardize quoting; simplify constant. |
| lib/mongo/error/invalid_txt_record.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_transaction_operation.rb | Remove opt-out; simplify constants; super passthrough. |
| lib/mongo/error/invalid_signature.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_session.rb | Remove opt-out; super passthrough. |
| lib/mongo/error/invalid_server_preference.rb | Remove opt-out; standardize quoting; super passthrough. |
| lib/mongo/error/invalid_server_auth_response.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_server_auth_host.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_replacement_document.rb | Remove opt-out; standardize quoting; simplify constant. |
| lib/mongo/error/invalid_read_option.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_read_concern.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_nonce.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_min_pool_size.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_file_revision.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_file.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_document.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/invalid_database_name.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/invalid_cursor_operation.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_config_option.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_collection_name.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/invalid_bulk_operation_type.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_bulk_operation.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_application_name.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/invalid_address.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/internal_driver_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/insufficient_iteration_count.rb | Remove opt-out; super passthrough. |
| lib/mongo/error/handshake_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/file_not_found.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/failed_string_prep_validation.rb | Remove opt-out; standardize constants; super passthrough. |
| lib/mongo/error/extra_file_chunk.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/crypt_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/credential_check_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/connection_unavailable.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/connection_perished.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/connection_check_out_timeout.rb | Remove opt-out; simplify required address validation. |
| lib/mongo/error/closed_stream.rb | Remove opt-out; standardize quoting. |
| lib/mongo/error/client_closed.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/change_stream_resumable.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/bulk_write_error.rb | Remove opt-out; improve nil-message handling + string formatting. |
| lib/mongo/error/bad_load_balancer_target.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error/auth_error.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/error.rb | Remove opt-out; simplify constants; fix numeric .freeze misuse. |
| lib/mongo/database/view.rb | Remove opt-out; minor signature/comment/style changes. |
| lib/mongo/cursor_host.rb | Remove inline RuboCop Metrics disable/enable directives. |
| lib/mongo/cursor/kill_spec.rb | Remove opt-out; simplify eql?. |
| lib/mongo/crypt/status.rb | Remove opt-out; refactor validation + digest/label constants style. |
| lib/mongo/crypt/rewrap_many_data_key_result.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/rewrap_many_data_key_context.rb | Remove opt-out; simplify conditional call. |
| lib/mongo/crypt/kms_context.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/kms/master_key_document.rb | Remove opt-out; %w[] + guard simplification. |
| lib/mongo/crypt/kms/local/master_document.rb | Remove opt-out; inline empty initializer; quoting style. |
| lib/mongo/crypt/kms/local/credentials.rb | Remove opt-out; simplify empty guard + formatting. |
| lib/mongo/crypt/kms/kmip/master_document.rb | Remove opt-out; quoting style. |
| lib/mongo/crypt/kms/kmip/credentials.rb | Remove opt-out; simplify empty guard + formatting. |
| lib/mongo/crypt/kms/gcp/master_document.rb | Remove opt-out; simplify conditional updates. |
| lib/mongo/crypt/kms/gcp/credentials_retriever.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/kms/gcp/credentials.rb | Remove opt-out; quoting style; simplify optional endpoint update. |
| lib/mongo/crypt/kms/gcp.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/kms/credentials.rb | Remove opt-out; simplify provider initialization and validation. |
| lib/mongo/crypt/kms/azure/master_document.rb | Remove opt-out; simplify optional keyVersion update. |
| lib/mongo/crypt/kms/azure/credentials_retriever.rb | Remove opt-out; simplify exception_class assignment. |
| lib/mongo/crypt/kms/aws/master_document.rb | Remove opt-out; simplify optional endpoint update. |
| lib/mongo/crypt/kms/aws/credentials.rb | Remove opt-out; simplify empty guard + optional token update. |
| lib/mongo/crypt/kms/aws.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/kms.rb | Remove opt-out; quoting style; minor loops/require formatting. |
| lib/mongo/crypt/hooks.rb | Remove opt-out; string quoting; digest creation style. |
| lib/mongo/crypt/explicit_encryption_expression_context.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/explicit_decryption_context.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/data_key_context.rb | Remove opt-out; simplify validations and quoting. |
| lib/mongo/crypt/context.rb | Remove opt-out; simplify loops/rescue; kms provider checks. |
| lib/mongo/crypt/binary.rb | Remove opt-out; simplify class constructors and guard clauses. |
| lib/mongo/crypt/auto_encryption_context.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt/auto_decryption_context.rb | Remove opt-out; whitespace normalization. |
| lib/mongo/crypt.rb | Remove opt-out comment. |
| lib/mongo/config/validators/option.rb | Remove opt-out; simplify validator guard. |
| lib/mongo/config/options.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/config.rb | Remove opt-out; standardize require quoting. |
| lib/mongo/condition_variable.rb | Remove opt-out; simplify guard clauses and quoting. |
| lib/mongo/collection/view/iterable.rb | Remove opt-out; each(&block) refactor; tighten close logic. |
| lib/mongo/collection/view/immutable.rb | Remove opt-out; add spacing after early return. |
| lib/mongo/collection/view/explainable.rb | Remove opt-out; simplify constants + verbosity conversion. |
| lib/mongo/collection/view/change_stream/retryable.rb | Remove opt-out; simplify resumable error flow. |
| lib/mongo/collection/view/builder/map_reduce.rb | Remove opt-out; hash key style + write? guard refactor. |
| lib/mongo/collection/view/builder/aggregation.rb | Remove opt-out; simplify write_concern update + hash style. |
| lib/mongo/collection/view/aggregation.rb | Remove opt-out; refactor match insertion + read pref checks. |
| lib/mongo/collection/view.rb | Remove opt-out; alias syntax + formatting in inspect and helpers. |
| lib/mongo/collection/helpers.rb | Remove opt-out; simplify NamespaceNotFound handling. |
| lib/mongo/cluster_time.rb | Remove opt-out; simplify lint guard and consumer update logic. |
| lib/mongo/cluster/topology/unknown.rb | Remove opt-out; expand one-liners and simplify constants. |
| lib/mongo/cluster/topology/sharded.rb | Remove opt-out; expand one-liners and simplify constants. |
| lib/mongo/cluster/topology/replica_set_with_primary.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/cluster/topology/no_replica_set_options.rb | Remove opt-out; %i[] + super passthrough. |
| lib/mongo/cluster/topology/load_balanced.rb | Remove opt-out; expand one-liners; wrap long error line. |
| lib/mongo/cluster/topology/base.rb | Remove opt-out; simplify loops/guards and split call formatting. |
| lib/mongo/cluster/topology.rb | Remove opt-out; wrap error messages and unify quoting. |
| lib/mongo/cluster/reapers/socket_reaper.rb | Remove opt-out; inline empty method. |
| lib/mongo/cluster/periodic_executor.rb | Remove opt-out; modern alias syntax; rescue StandardError. |
| lib/mongo/client_encryption.rb | Remove opt-out; modern alias syntax. |
| lib/mongo/caching_cursor.rb | Remove opt-out; each(&block) refactor. |
| lib/mongo/bulk_write/validatable.rb | Remove opt-out; simplify validation flags + guard clauses. |
| lib/mongo/bulk_write/unordered_combiner.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/bulk_write/result_combiner.rb | Remove opt-out; simplify conditionals with early returns. |
| lib/mongo/bulk_write/result.rb | Remove opt-out; simplify constants + validate! flow. |
| lib/mongo/bulk_write/ordered_combiner.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/bulk_write/combineable.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/bson.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/background_thread.rb | Remove opt-out; tighten loops and inline empty hooks. |
| lib/mongo/auth/x509/conversation.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/auth/x509.rb | Remove opt-out; simplify MECHANISM constant + wrap error. |
| lib/mongo/auth/user/view.rb | Remove opt-out; trailing comma removal. |
| lib/mongo/auth/user.rb | Remove opt-out; add spacing and simplify guards and messages. |
| lib/mongo/auth/stringprep/tables.rb | Remove opt-out comment. |
| lib/mongo/auth/stringprep/profiles/sasl.rb | Remove opt-out comment. |
| lib/mongo/auth/stringprep.rb | Remove opt-out; simplify bidi checks with early returns. |
| lib/mongo/auth/scram_conversation_base.rb | Remove opt-out; simplify payload parse + signature checks. |
| lib/mongo/auth/scram256/conversation.rb | Remove opt-out; digest instantiation style. |
| lib/mongo/auth/scram256.rb | Remove opt-out; simplify MECHANISM constant. |
| lib/mongo/auth/scram/conversation.rb | Remove opt-out; digest instantiation style. |
| lib/mongo/auth/scram.rb | Remove opt-out; simplify MECHANISM constant + formatting. |
| lib/mongo/auth/sasl_conversation_base.rb | Remove opt-out; tighten lint checks and nonce validation. |
| lib/mongo/auth/ldap/conversation.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/auth/ldap.rb | Remove opt-out; simplify MECHANISM constant. |
| lib/mongo/auth/gssapi/conversation.rb | Remove opt-out; simplify require guard and hash style. |
| lib/mongo/auth/gssapi.rb | Remove opt-out; simplify MECHANISM constant. |
| lib/mongo/auth/credential_cache.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/auth/cr/conversation.rb | Remove opt-out comment / whitespace normalization. |
| lib/mongo/auth/cr.rb | Remove opt-out; simplify MECHANISM constant. |
| lib/mongo/auth/conversation_base.rb | Remove opt-out; ignore unused opts; simplify selector construction. |
| lib/mongo/auth/base.rb | Remove opt-out; ignore unused opts; simplify validation/dispatch. |
| lib/mongo/auth/aws/conversation.rb | Remove opt-out; wrap long error; simplify optional token handling. |
| lib/mongo/auth/aws.rb | Remove opt-out; simplify MECHANISM constant. |
| lib/mongo/address/unix.rb | Remove opt-out; ignore unused params in initializer. |
| lib/mongo/address/ipv6.rb | Remove opt-out; match? usage; port numeric readability. |
| lib/mongo/address/ipv4.rb | Remove opt-out; simplify constants and port numeric readability. |
| lib/mongo/active_support.rb | Remove opt-out; standardize require quoting. |
| lib/mongo.rb | Remove opt-out; remove stray whitespace; standardize quoting. |
| gemfiles/standard.rb | Remove rubocop disable block; adjust trailing enable directive. |
| examples/update.rb | Remove opt-out comment. |
| Rakefile | Add rubocop tasks + hook installer; remove Metrics/BlockLength disable. |
| .rubocop.yml | Inherit from .rubocop_todo.yml and merge Exclude settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is to try and figure out why the rubocop task is checking out the wrong SHA
comandeo-mongo
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we have opted most of the files out of the linter with
# rubocop:todo allat the top of most of them. This PR removes that line and instead adds exceptions to a new.rubocop_todo.ymlfile. This PR also applies (viarubocop -a) standard string quoting and most other safely "autocorrectable" cops.