Skip to content

RUBY-3789 disambiguate spec test names#3007

Merged
comandeo-mongo merged 1 commit intomongodb:masterfrom
jamis:3789-test-overload-retry-when-retries-false
Mar 31, 2026
Merged

RUBY-3789 disambiguate spec test names#3007
comandeo-mongo merged 1 commit intomongodb:masterfrom
jamis:3789-test-overload-retry-when-retries-false

Conversation

@jamis
Copy link
Copy Markdown
Contributor

@jamis jamis commented Mar 27, 2026

The rest of this ticket was previously implemented as part of RUBY-3706.

The rest of this ticket was previously implemented as part of RUBY-3706
@jamis jamis requested a review from a team as a code owner March 27, 2026 18:06
@jamis jamis requested review from comandeo-mongo and Copilot March 27, 2026 18:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disambiguates client backpressure spec test names (read vs write aggregates) and makes small readability tweaks in transaction timeout handling.

Changes:

  • Update backpressure spec YAML test descriptions to distinguish read vs write aggregate scenarios.
  • Refactor with_transaction commit-time timeout handling for clearer control flow.
  • Simplify make_timeout_error_from branching.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
spec/spec_tests/data/client_backpressure/backpressure-retry-max-attempts.yml Renames aggregate retry tests to explicitly indicate read vs write semantics.
spec/spec_tests/data/client_backpressure/backpressure-retry-loop.yml Renames aggregate retry-loop tests to explicitly indicate read vs write semantics.
lib/mongo/session.rb Minor refactors around withTransaction timeout/raise paths; adds RuboCop suppression on the transaction loop.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

overload_encountered = false

loop do
loop do # rubocop:disable Metrics/BlockLength
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# rubocop:disable Metrics/BlockLength without a corresponding rubocop:enable will disable this cop for the remainder of the file. Add a matching # rubocop:enable Metrics/BlockLength after the loop block (or use a disable/enable pair around the minimal span) so the suppression is scoped appropriately.

Copilot uses AI. Check for mistakes.
@comandeo-mongo comandeo-mongo merged commit 43c94ee into mongodb:master Mar 31, 2026
202 of 208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants