RUBY-3789 disambiguate spec test names#3007
Merged
comandeo-mongo merged 1 commit intomongodb:masterfrom Mar 31, 2026
Merged
Conversation
The rest of this ticket was previously implemented as part of RUBY-3706
Contributor
There was a problem hiding this comment.
Pull request overview
Disambiguates client backpressure spec test names (read vs write aggregates) and makes small readability tweaks in transaction timeout handling.
Changes:
- Update backpressure spec YAML test descriptions to distinguish read vs write
aggregatescenarios. - Refactor
with_transactioncommit-time timeout handling for clearer control flow. - Simplify
make_timeout_error_frombranching.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/spec_tests/data/client_backpressure/backpressure-retry-max-attempts.yml | Renames aggregate retry tests to explicitly indicate read vs write semantics. |
| spec/spec_tests/data/client_backpressure/backpressure-retry-loop.yml | Renames aggregate retry-loop tests to explicitly indicate read vs write semantics. |
| lib/mongo/session.rb | Minor refactors around withTransaction timeout/raise paths; adds RuboCop suppression on the transaction loop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| overload_encountered = false | ||
|
|
||
| loop do | ||
| loop do # rubocop:disable Metrics/BlockLength |
There was a problem hiding this comment.
# rubocop:disable Metrics/BlockLength without a corresponding rubocop:enable will disable this cop for the remainder of the file. Add a matching # rubocop:enable Metrics/BlockLength after the loop block (or use a disable/enable pair around the minimal span) so the suppression is scoped appropriately.
comandeo-mongo
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of this ticket was previously implemented as part of RUBY-3706.