RUBY-3623 Rename WriteConcernFailed code name to WriteConcernTimeout#3032
Merged
comandeo-mongo merged 1 commit intomongodb:masterfrom Apr 28, 2026
Merged
Conversation
Sync the spec test fixtures to match mongodb/specifications@b643abfb (DRIVERS-3007). Drop codeName from failpoint configs so the server fills in its own (post-rename WriteConcernTimeout, pre-rename WriteConcernFailed) and update test descriptions accordingly. Error code 64 is unchanged. Also update the corresponding driver-specific failpoint test in auth/user/view_spec.rb to use the new name in both the failpoint config and the assertion.
jamis
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync the spec test fixtures to match mongodb/specifications@b643abfb
(DRIVERS-3007). The server has renamed error code 64's name from
WriteConcernFailedtoWriteConcernTimeout; the numeric code isunchanged.
The spec change drops
codeName: WriteConcernFailedfrom failpointconfigs (so the server returns its version-appropriate name) and
updates test descriptions and surrounding comments. This PR mirrors
those edits in the Ruby driver's local copies of the affected
fixtures.
The driver-specific failpoint test in
spec/mongo/auth/user/view_spec.rbsets
codeNameitself and asserts on the echoed value, so both thefailpoint and the assertion are updated to the new name.
Test plan
bundle exec rspec spec/mongo/auth/user/view_spec.rb— 55 examples, 0 failures (4 unrelated pending)bundle exec rspec spec/spec_tests/retryable_writes_spec.rb -e 'WriteConcernTimeout'— replica-set examples ran and passed; sharded ones pending as expectedbundle exec rubocop spec/mongo/auth/user/view_spec.rb— clean