RUBY-3824 Restore conditional skip logic in transactions spec runner

[comandeo-mongo]

A rubocop autocorrect in commit
8db64312b
("Enable rubocop on all files, with exceptions" — #3005) flattened
the original if test.skip_reason and unless req.satisfied? guards
in spec/runners/transactions.rb into bare skip calls inside a
single before(:all) block:

before(:all) do
  ...
  skip test.skip_reason            # always skips, even when nil
  skip 'Requirements not satisfied' # always skips
  test.setup_test                   # never reached
end

Effect: every transactions_spec.rb and transactions_api_spec.rb
example reports as PENDING regardless of topology or actual
requirements. The transactions spec test suite has not run locally on
master since that commit (2026-03-27).

The fix restores the conditional checks and passes req through to
the block (it was renamed to _req because it had become unused after
the regression).

Test plan

Against a local 3-node replica set (replicaSet=replset):

• bundle exec rspec spec/spec_tests/transactions_spec.rb — 1809 examples, 0 failures, 965 pending (sharded-only). Before: all pending.
• bundle exec rspec spec/spec_tests/transactions_api_spec.rb — 370 examples, 0 failures, 185 pending (sharded-only). Before: all pending.
• bundle exec rubocop spec/runners/transactions.rb — clean

[Copilot]

Pull request overview

Restores correct conditional skipping behavior in the transactions spec runner so that transaction spec tests execute when applicable instead of always being marked pending.

Changes:

• Reintroduces conditional guard for test.skip_reason before calling skip.
• Reintroduces conditional guard for spec req satisfaction before skipping due to unmet requirements.
• Restores use of the req argument yielded by define_spec_tests_with_requirements.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jamis]

Great catch! I was afraid something like this might slip through the cracks, after I discovered that the supposedly "safe" Rubocop autocorrect mode (-a) is not actually guaranteed to be safe. Thanks for fixing this. 👍