Skip to content

RUBY-3824 Restore conditional skip logic in transactions spec runner #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comandeo-mongo merged 2 commits into from
Apr 29, 2026
+32 −4
Merged

RUBY-3824 Restore conditional skip logic in transactions spec runner #3033

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c165d46
RUBY-3824 Restore conditional skip logic in transactions spec runner
comandeo-mongo Apr 28, 2026
04bee77
RUBY-3824 Make Session#unpin idempotent
comandeo-mongo Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions spec/runners/transactions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def define_transactions_spec_tests(test_paths, expectations_bson_types: true)
spec = Mongo::Transactions::Spec.new(file)

context(spec.description) do
define_spec_tests_with_requirements(spec) do |_req|
define_spec_tests_with_requirements(spec) do |req|
spec.tests(expectations_bson_types: expectations_bson_types).each do |test|
context(test.description) do
before(:all) do
Expand All @@ -38,9 +38,8 @@ def define_transactions_spec_tests(test_paths, expectations_bson_types: true)
skip 'Test does not specify multiple mongoses'
end
end
skip test.skip_reason

skip 'Requirements not satisfied'
skip test.skip_reason if test.skip_reason
skip 'Requirements not satisfied' unless req.satisfied?

test.setup_test
end
Expand Down
Loading