RUBY-3812 Don't use the legacy datasets for bson benchmarks#3059
Open
jamis wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DriverBench data download rake task to avoid unpacking legacy benchmarking datasets on top of the current datasets, ensuring benchmarks use the intended (non-legacy) data.
Changes:
- Skip extracting
.tgzarchives identified as legacy datasets during the data download/unpack step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mkdir_p DRIVER_BENCH_DATA | ||
|
|
||
| Dir.glob(File.join(SPECS_PATH, 'source/benchmarking/data/*.tgz')) do |archive| | ||
| next if archive.include?('legacy') # skip the legacy data sets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy data sets were being unpacked on top of the recent data sets, and so the recent data sets were never being used by the benchmarks. This PR explicitly skips the legacy data sets so they don't clobber the recent ones.