You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi here, playing Mongo for a while so trying to get exposure to driver side's world as well.
Picking some small wins here: RUST-2369 if you don't mind.
This pr adds public constructor methods to ReadPreference so users can build variants without the verbose struct syntax.
Before:
let rp = ReadPreference::PrimaryPreferred{options:None};
After:
let rp = ReadPreference::primary_preferred(None);let rp = ReadPreference::primary_preferred(options);
thanks for review in advance.
if I've missed any convention here, please let me know and I'll fix it right away.
Thanks for your review! @abr-egn
Sorry for the late reply -- wasn't a wfh day for me. Just rebased onto that commit. Out of curiosity, is there a specific reason for rebasing onto that commit rather than the latest merged one? Still getting familiar with the testing setup here, so apologies if this is a naive question!
Out of curiosity, is there a specific reason for rebasing onto that commit rather than the latest merged one? Still getting familiar with the testing setup here, so apologies if this is a naive question!
That was the one that fixed the tests is all, rebasing to latest would also have been fine 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi here, playing Mongo for a while so trying to get exposure to driver side's world as well.
Picking some small wins here: RUST-2369 if you don't mind.
This pr adds public constructor methods to
ReadPreferenceso users can build variants without the verbose struct syntax.Before:
After:
thanks for review in advance.
if I've missed any convention here, please let me know and I'll fix it right away.