TOOLS-4235 More Evergreen config cleanup#1023
Open
autarch wants to merge 1 commit into
Open
Conversation
This removes the deliberate_fail_to_test_build_baron_context_rules task and cleans up some escaping in the Evergreen config. It also removes the need for escaping a string in YAML by interpolating it into bash code with single quotes instead of double.
autarch
requested review from
fancywriter and
mmcclimon
and removed request for
a team
mmcclimon
approved these changes
Jul 10, 2026
| mkdir -p /data/db/ | ||
| if [ "${USE_TLS}" = "true" ]; then | ||
| NODE_OPTIONS="${replsettest_tls_config}" | ||
| NODE_OPTIONS='${replsettest_tls_config}' |
Collaborator
There was a problem hiding this comment.
I am a little surprised this works? I would expect this to set NODE_OPTIONS to the literal string ${replsettest_tls_config}. Clearly I'm wrong, though, so chalking this up to evergreen + yaml + bash code in string is not the best way to write programs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
deliberate_fail_to_test_build_baron_context_rulestask and cleans up some escaping in the Evergreen config.It also removes the need for escaping a string in YAML by interpolating it into bash code with single quotes instead of double.