TOOLS-4102 Use mise to execute go as well as other dev tools#896
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
autarch
force-pushed
the
02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools
branch
from
6540086 to
a2a3687
Compare
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
from
2cd5cd3 to
4f2e904
Compare
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
from
4f2e904 to
f5d92f4
Compare
autarch
force-pushed
the
02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools
branch
from
a2a3687 to
8202f34
Compare
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
from
f5d92f4 to
066bc67
Compare
autarch
changed the base branch from
02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools
to
graphite-base/896
autarch
force-pushed
the
graphite-base/896
branch
from
8202f34 to
48c54ef
Compare
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
from
066bc67 to
779bbdc
Compare
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
2 times, most recently
from
b3992d5 to
e8a0c62
Compare
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
from
e8a0c62 to
be24102
Compare
Collaborator
Author
|
evergreen retry |
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
10 times, most recently
from
88abd32 to
5ca7eb4
Compare
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
from
5ca7eb4 to
ab1f72d
Compare
This gets rid of the Go code to install dev tools entirely, and updates all the places we call these tools to use `mise exec`.
autarch
force-pushed
the
02-25-tools-4102-use-mise-to-execute-go
branch
from
ab1f72d to
9dc0e39
Compare
mmcclimon
approved these changes
Jul 7, 2026
mmcclimon
left a comment
mmcclimon
left a comment
Collaborator
There was a problem hiding this comment.
Sure; I didn't scrutinize every line of this, but if it works in CI on the platforms we need it to, fine by me.
Comment on lines
+25
to
+26
| powershell.exe -NoProfile -Command \ | ||
| "Expand-Archive -Path '$(cygpath -w "$tmp_zip")' -DestinationPath '$(cygpath -w "$tmp_extract")' -Force" |
Collaborator
There was a problem hiding this comment.
picture me smiling and nodding at PowerShell. (I'm just assuming this works.)
Collaborator
Author
There was a problem hiding this comment.
I mean, CI works, so I'm pretty sure this does the thing we need.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the Go code to install dev tools entirely, and updates (almost) all the places we call these tools to use
mise exec. We use Evergreen's caching to cachemiseand the tools it installs.There were a number of complicating factors here.
First, the mise install shell script does not work under Cygwin, which is how it gets run in Evergreen. This means that we need to manually download the Windows tarball for mise and install it.
Second, there are no mise releases for s390x or PowerPC architectures (see jdx/mise#10835). On those platforms, we only need Go and we only use it to do a build. We don't run tests. So we have a new, separate script to find/install Go on thse platforms. We generally expect that the Go we need will already be installed under
/opt/golang/go$version, so we chec for tha first. If it doesn't exist, we download and unpack an official Go release tarball instead. Regardless, we do not cache the Go install on these platforms, because of issues with Evergreen caching and symlinks (see comments in the script for more details).