Skip to content

TOOLS-4142 Estimate 1 MB for message overhead #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tdq45gj wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Draft

TOOLS-4142 Estimate 1 MB for message overhead #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions common/db/buffered_bulk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,10 @@ func newBufferedBulkInserter(
docLimit: docLimit,
// We set the byte limit to be slightly lower than maxMessageSizeBytes so it can fit in one OP_MSG.
// This may not always be perfect, e.g. we don't count update selectors in byte totals, but it should
// be good enough to keep memory consumption in check.
byteLimit: MAX_MESSAGE_SIZE_BYTES - 100,
// be good enough to keep memory consumption in check. Because we cannot reliably predict the total
// size of the message that will be sent by the go-driver, the 1MB buffer for message overhead is
// a conservative estimate chosen arbitrarily.
byteLimit: MAX_MESSAGE_SIZE_BYTES - 1_000_000,
writeModels: make([]mongo.WriteModel, 0, docLimit),
canDoZeroTimestamp: zeroTimestampOk,
}
Expand Down