chore: remove redundant wrapper for nsToDatabaseSubstring

Author: EdanStasiuk

src/mongo/db/namespace_string.h

@@ -894,15 +894,6 @@ inline StringData nsToDatabaseSubstring(StringData ns) {
     return ns.substr(0, i);
 }
 
-/**
- * "database.a.b.c" -> "database"
- *
- * TODO: make this return a StringData
- */
-inline std::string nsToDatabase(StringData ns) {
-    return std::string{nsToDatabaseSubstring(ns)};
-}
-
 /**
  * "database.a.b.c" -> "a.b.c"
  */

src/mongo/db/namespace_string_test.cpp

@@ -230,10 +230,6 @@ TEST_F(NamespaceStringTest, DbForSharding) {
 TEST_F(NamespaceStringTest, nsToDatabase1) {
     ASSERT_EQUALS("foo", nsToDatabaseSubstring("foo.bar"));
     ASSERT_EQUALS("foo", nsToDatabaseSubstring("foo"));
-    ASSERT_EQUALS("foo", nsToDatabase("foo.bar"));
-    ASSERT_EQUALS("foo", nsToDatabase("foo"));
-    ASSERT_EQUALS("foo", nsToDatabase(std::string("foo.bar")));
-    ASSERT_EQUALS("foo", nsToDatabase(std::string("foo")));
 }
 
 TEST_F(NamespaceStringTest, NamespaceStringParse1) {