fix: respect client retryability settings

Author: nbbeeken

src/operations/execute_operation.ts

@@ -389,12 +389,18 @@ async function executeOperationWithRetries<
   );
 
   function canRetry(operation: AbstractOperation, error: MongoError) {
-    // always retryable
+    // SystemOverloadedError is retryable, but still must respect retryReads/retryWrites settings
     if (
       error.hasErrorLabel(MongoErrorLabel.SystemOverloadedError) &&
       error.hasErrorLabel(MongoErrorLabel.RetryableError)
     ) {
-      return true;
+      // runCommand requires BOTH retryReads and retryWrites to be enabled (per spec)
+      if (operation instanceof RunCommandOperation) {
+        return willRetryRead && willRetryWrite;
+      }
+
+      // For other operations, check if retries are enabled for the operation type
+      return (hasReadAspect && willRetryRead) || (hasWriteAspect && willRetryWrite);
     }
 
     // run command is only retryable if we get retryable overload errors

test/integration/client-backpressure/client-backpressure.spec.test.ts

@@ -4,6 +4,8 @@ import { type Test } from '../../tools/unified-spec-runner/schema';
 
 const skippedTests = {
   'collection.dropIndexes retries at most maxAttempts=5 times':
+    'TODO(NODE-6517): dropIndexes squashes all errors other than ns not found',
+  'collection.dropIndexes (write) does not retry if retryWrites=false':
     'TODO(NODE-6517): dropIndexes squashes all errors other than ns not found'
 };