test(NODE-6626): implement integration tests for improved client.close() - server-side#4367
Merged
baileympearson merged 18 commits intomainfrom Mar 12, 2025
Merged
test(NODE-6626): implement integration tests for improved client.close() - server-side#4367baileympearson merged 18 commits intomainfrom
baileympearson merged 18 commits intomainfrom
Conversation
34ccf67 to
804c464
Compare
baileympearson
suggested changes
Jan 13, 2025
Contributor
baileympearson
left a comment
There was a problem hiding this comment.
One comment about unskipping tests that pass, and some optional comments. Otherwise LGTM
ddb638d to
13a8a25
Compare
baileympearson
previously approved these changes
Jan 23, 2025
The base branch was changed.
8adfee6 to
08d8c26
Compare
nbbeeken
requested changes
Jan 23, 2025
7348d39 to
74673f8
Compare
nbbeeken
requested changes
Jan 28, 2025
Contributor
nbbeeken
left a comment
There was a problem hiding this comment.
"the server-side ServerSession is cleaned up by client.close():"
test is failing, this one we can unskip but I think the issue is something with the namespace already/not existing?
Contributor
Author
|
@nbbeeken Error should be gone now but I'll wait for tests to pass on full CI before re-requesting review. I'm skipping the sessions tests on versions < 4.2 since that's what the $currentOp API requires to detect idleSessions |
013aee7 to
d522a1f
Compare
baileympearson
suggested changes
Mar 5, 2025
test/integration/node-specific/resource_tracking_script_builder.ts
Outdated
Show resolved
Hide resolved
baileympearson
suggested changes
Mar 7, 2025
baileympearson
suggested changes
Mar 7, 2025
Contributor
baileympearson
left a comment
There was a problem hiding this comment.
one other comment
b25536d to
4c1d06c
Compare
baileympearson
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add server-side resource integration tests for client.close(). These tests will remain skipped until improved client.close() is implemented.
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Improved client.close()
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript