feat(NODE-6773): add support for $lookup on encrypted collections#4427
Merged
baileympearson merged 17 commits intomainfrom Feb 28, 2025
Merged
feat(NODE-6773): add support for $lookup on encrypted collections#4427baileympearson merged 17 commits intomainfrom
baileympearson merged 17 commits intomainfrom
Conversation
5 tasks
nbbeeken
force-pushed
the
NODE-6774-fle-lookup
branch
2 times, most recently
from
813223f to
ffb01de
Compare
Contributor
Author
|
Will update the bindings when they are available, we can still start reviewing what is in here in the meantime |
baileympearson
changed the title
baileympearson
suggested changes
Feb 24, 2025
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
There are pending spec test changes from Maxim, I'll re-review the tests when Kevin has updated the prose tests in his PR.
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
nbbeeken
added
the
Primary Review
nbbeeken
force-pushed
the
NODE-6774-fle-lookup
branch
2 times, most recently
from
715c23d to
4f797c9
Compare
nbbeeken
force-pushed
the
NODE-6774-fle-lookup
branch
from
2384e2e to
e7ec664
Compare
addaleax
reviewed
Feb 27, 2025
baileympearson
suggested changes
Feb 27, 2025
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
commented
Feb 27, 2025
Contributor
Author
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
all comments should be addressed, but waiting for the release to publish so I can update our dev dep.
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts
Show resolved
Hide resolved
baileympearson
approved these changes
Feb 27, 2025
baileympearson
added
Team Review
addaleax
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
adds tests for lookup support
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Add support for $lookup on encrypted collections
Starting in the upcoming MongoDB server 8.1, the aggregation stage
$lookupcan now be used with clients configured for automatic encryption after upgrading tomongodb-client-encryption@>=6.3.0! 🔒 🎉Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript