-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-7142): Exponential backoff and jitter in retry loops #4871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7c08fb5
POC
baileympearson 4100da7
deposit retry tokens only on retries, update maxAttempts property con…
tadjik1 091e989
update to latest, small clean-ups
tadjik1 680ee08
add timeoutContext to retry selectServer
tadjik1 0c36556
revert non-compliant spec change
tadjik1 a4caf38
always cleanup local timeout (also for sharded clusters)
tadjik1 89eafde
do not leak the timeout also in normal path finally block
tadjik1 50d5c2c
run all tests
tadjik1 85f10c3
define constants
tadjik1 b048983
export TokenBucket
tadjik1 adcdc4f
retry batching commands only on retryable errors
tadjik1 ea394cb
Apply suggestions from code review
tadjik1 b7cf299
do not change package-lock.json
tadjik1 6cf961f
initialize attemptsMade
tadjik1 2bce2a4
move export of TokenBucket type into "internal" section
tadjik1 412a779
implement prose test #2; re-arrange export of TokenBucket type
tadjik1 3ac26b7
extend spec test for retry write transaction
tadjik1 ac9e097
run updated transactions tests
tadjik1 805ef19
run prev. version of the tests
tadjik1 02f2b18
do not validate TokenBucket export
tadjik1 1e06a01
remove duplicated @internal label from tokenbucket property
tadjik1 daa1c7f
do not return 1 from timer stub
tadjik1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.