Skip to content

test(NODE-7464): sync backpressure getMore-retried tests to latest#4889

Merged
dariakp merged 2 commits intomainfrom
NODE-7464/sync-backpressure-getmore-retried-tests
Mar 13, 2026
Merged

test(NODE-7464): sync backpressure getMore-retried tests to latest#4889
dariakp merged 2 commits intomainfrom
NODE-7464/sync-backpressure-getmore-retried-tests

Conversation

@dariakp
Copy link
Copy Markdown
Contributor

@dariakp dariakp commented Mar 10, 2026

Description

NODE-7464

Summary of Changes

  • sync backpressure getMore-retried tests to latest
  • remove unnecessary template files from test directory

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review March 12, 2026 14:27
@dariakp dariakp requested a review from a team as a code owner March 12, 2026 14:27
Copilot AI review requested due to automatic review settings March 12, 2026 14:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs the client-backpressure “getMore-retried” unified spec tests with the latest upstream expectations and removes obsolete template sources from the spec directory.

Changes:

  • Add useMultipleMongoses: false to relevant clients in the getMore-retried unified spec (YAML + extended JSON) to ensure deterministic behavior in sharded/LB environments.
  • Normalize whitespace/formatting in getMore-retried.yml expected event blocks (no behavioral change).
  • Remove unused client-backpressure YAML template files from the test/spec directory.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/spec/client-backpressure/getMore-retried.yml Pins clients to a single mongos and cleans up formatting in the unified spec test.
test/spec/client-backpressure/getMore-retried.json Mirrors the YAML entity change (useMultipleMongoses: false) in the JSON form of the same spec test.
test/spec/client-backpressure/backpressure-retry-max-attempts.yml.template Deletes an unused generator template file from the spec directory.
test/spec/client-backpressure/backpressure-retry-loop.yml.template Deletes an unused generator template file from the spec directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PavelSafronov PavelSafronov self-assigned this Mar 12, 2026
@PavelSafronov PavelSafronov added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 12, 2026
@dariakp dariakp merged commit 275afa5 into main Mar 13, 2026
34 checks passed
@dariakp dariakp deleted the NODE-7464/sync-backpressure-getmore-retried-tests branch March 13, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants