Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the prose comments for Retryable Writes spec test 6, case 3 to use consistent and correct wording for the described failpoint/error-label sequence.
Changes:
- Corrects the wording around error code
91(ShutdownInProgress) vs prior inconsistent phrasing. - Clarifies the intended ordering of failpoint behavior: first error without
NoWritesPerformed, subsequent errors withNoWritesPerformed. - Updates the embedded failpoint examples (
modeanderrorLabels) to match the described scenario.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tadjik1
approved these changes
Apr 8, 2026
Member
tadjik1
left a comment
tadjik1
left a comment
There was a problem hiding this comment.
Thanks @PavelSafronov!
I will merge PR once CI is complete.
tadjik1
added
the
Primary Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript