Skip to content

chore(NODE-7473): upgrade to chai 5 #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PavelSafronov wants to merge 2 commits into
base: main
Choose a base branch
from
+45 −77
Open

chore(NODE-7473): upgrade to chai 5 #4958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80947fd
chore(NODE-7473): upgrade to chai 5
PavelSafronov Jun 5, 2026
ceef4cb
require fix
PavelSafronov Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 36 additions & 70 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
"@microsoft/api-extractor": "^7.54.0",
"@microsoft/tsdoc-config": "^0.17.1",
"@mongodb-js/zstd": "^7.0.0",
"@types/chai": "^4.3.17",
"@types/chai-subset": "^1.3.5",
"@types/express": "^5.0.5",
"@types/kerberos": "^1.1.5",
Expand All @@ -77,12 +76,11 @@
"@types/saslprep": "^1.0.3",
"@types/semver": "^7.7.0",
"@types/sinon": "^17.0.4",
"@types/sinon-chai": "^4.0.0",
"@types/whatwg-url": "^13.0.0",
"@typescript-eslint/eslint-plugin": "^8.46.3",
"@typescript-eslint/parser": "^8.31.1",
"aws4": "^1.13.2",
"chai": "^4.4.1",
"chai": "^5.3.3",
"chai-subset": "^1.6.0",
"chalk": "^4.1.2",
"esbuild": "^0.27.2",
Expand All @@ -103,7 +101,7 @@
"prettier": "^3.6.2",
"semver": "^7.7.2",
"sinon": "^18.0.1",
"sinon-chai": "^3.7.0",
"sinon-chai": "^4.0.1",
"snappy": "^7.3.2",
"socks": "^2.8.7",
"source-map-support": "^0.5.21",
Expand Down
6 changes: 5 additions & 1 deletion test/action/dependency.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ describe('package.json', function () {
after('reset npm dependencies', () => {
// This test file is not meant to be run alongside others, but in case
// we can attempt to reset the environment
fs.rmSync(path.join(repoRoot, 'node_modules'), { recursive: true, force: true });
fs.rmSync(path.join(repoRoot, 'node_modules'), {
recursive: true,
force: true,
maxRetries: 3 // Retry in case of transient file system errors
});
execSync(`npm clean-install`);
});

Expand Down
2 changes: 1 addition & 1 deletion test/manual/kerberos.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { MongoClient } from '../mongodb';
const expect = chai.expect;

// eslint-disable-next-line @typescript-eslint/no-require-imports
chai.use(require('sinon-chai'));
chai.use(require('sinon-chai').default);

@johnmtll johnmtll Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use imports here & in other applicable spots? Would allow us to sunset the rule exclusion.

Suggested change
chai.use(require('sinon-chai').default);
import sinonChai from 'sinon-chai';
...
chai.use(sinonChai);


async function verifyKerberosAuthentication(client) {
const docs = await client.db('kerberos').collection('test').find().toArray();
Expand Down
2 changes: 1 addition & 1 deletion test/tools/runner/chai_addons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable @typescript-eslint/no-require-imports */
import chai = require('chai');

chai.use(require('sinon-chai'));
chai.use(require('sinon-chai').default);
chai.use(require('chai-subset'));
chai.use(require('../spec-runner/matcher').default);

Expand Down
Loading