fix: address review feedback

Author: ennajari

.gitignore

@@ -133,6 +133,3 @@ frontend/static/webfonts-preview
 frontend/.env.sentry-build-plugin
 .claude/worktrees
 1024MiB
-.scannerwork/
-.claude/
-sonar-project.properties

backend/src/dal/connections.ts

@@ -331,7 +331,7 @@ export async function aggregateWithAcceptedConnections<T>(
 
 function getKey(initiatorUid: string, receiverUid: string): string {
   const ids = [initiatorUid, receiverUid];
-  ids.sort((a, b) => a.localeCompare(b));
+  ids.sort();
   return ids.join("/");
 }
 

frontend/src/ts/modals/user-report.ts

@@ -72,7 +72,7 @@ export async function show(options: ShowOptions): Promise<void> {
     },
   });
 
-  new CharacterCounter(modal.getModal().qsr(".comment"), 250); // NOSONAR - constructor registers DOM listeners as side effect
+  new CharacterCounter(modal.getModal().qsr(".comment"), 250);
 }
 
 async function hide(): Promise<void> {

frontend/src/ts/utils/misc.ts

@@ -539,7 +539,6 @@ export function promiseWithResolvers<T = void>(): {
 
   const promiseLike = {
     // oxlint-disable-next-line no-thenable promise-function-async require-await
-    // NOSONAR
     async then<TResult1 = T, TResult2 = never>(
       onfulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | null,
       onrejected?: