fix(profile-search): prevent form.reset() from clearing first character on input (@AzureNightlock) (#7851)

### Description
This PR: Fixes the first character being skipped on input by only
clearing the form when the page isn't open.

Changes Made:
* form.reset() runs only when isOpen is false, Hence clearing the form
when the user leaves the page. When the user comes back to the page, the
form is cleared instead of clearing when the user first enters the page

Additional Changes Made:
* Removed the unused catch parameter ("e") from onChangeAsync.
* showIndicator doesn't show up when the field is blank

### Checks

- [x] Check if any open issues are related to this PR; if so, be sure to
tag them below.
- [x] Make sure the PR title follows the Conventional Commits standard.
(https://www.conventionalcommits.org for more info)
- [x] Make sure to include your GitHub username prefixed with @ inside
parentheses at the end of the PR title.

Closes #7850

Co-authored-by: Christian Fehmer <fehmer@users.noreply.github.com>

Author: AzureNightlock

frontend/src/ts/components/pages/profile/ProfileSearchPage.tsx

@@ -42,10 +42,11 @@ export function ProfileSearchPage(): JSXElement {
 
   createEffect(() => {
     if (isOpen()) {
-      form.reset();
       requestAnimationFrame(() => {
         inputEl()?.qs("input")?.focus({ preventScroll: true });
       });
+    } else {
+      form.reset();
     }
   });
 
@@ -77,7 +78,7 @@ export function ProfileSearchPage(): JSXElement {
                         getUserProfile(field.value),
                       );
                       return result !== null ? undefined : "Unknown user";
-                    } catch (e) {
+                    } catch {
                       return "Unknown user";
                     }
                   },