Skip to content

Commit fe7da09

Browse files
authored
refactor: test events phase 2 (@Miodec) (#8036)
Yeet everything, derive from events.
1 parent 9d0fe17 commit fe7da09

39 files changed

Lines changed: 1004 additions & 2232 deletions

backend/src/api/controllers/result.ts

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ import {
4343
GetResultsResponse,
4444
UpdateResultTagsRequest,
4545
UpdateResultTagsResponse,
46-
ReportCompletedEventMismatchRequest,
4746
} from "@monkeytype/contracts/results";
4847
import {
4948
CompletedEvent,
@@ -185,48 +184,6 @@ export async function updateTags(
185184
});
186185
}
187186

188-
export async function reportCompletedEventMismatch(
189-
req: MonkeyRequest<undefined, ReportCompletedEventMismatchRequest>,
190-
): Promise<MonkeyResponse> {
191-
const { uid } = req.ctx.decodedToken;
192-
const {
193-
notMatching,
194-
mismatchedKeys,
195-
groupKey,
196-
language,
197-
mode,
198-
mode2,
199-
difficulty,
200-
duration,
201-
funboxes,
202-
version,
203-
eventLog,
204-
} = req.body;
205-
// Logger.warning(
206-
// `Completed event mismatch for uid ${uid}: ${notMatching.join(", ")}`,
207-
// );
208-
// Logger.warning(`Old CE: ${JSON.stringify(ce)}`);
209-
// Logger.warning(`New CE: ${JSON.stringify(ce2)}`);
210-
void addLog(
211-
"completed_event_mismatch",
212-
{
213-
notMatching,
214-
mismatchedKeys,
215-
groupKey,
216-
language,
217-
mode,
218-
mode2,
219-
difficulty,
220-
duration,
221-
funboxes,
222-
version,
223-
eventLog,
224-
},
225-
uid,
226-
);
227-
return new MonkeyResponse("Mismatch reported", null);
228-
}
229-
230187
export async function addResult(
231188
req: MonkeyRequest<undefined, AddResultRequest>,
232189
): Promise<AddResultResponse> {

backend/src/api/routes/results.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ export default s.router(resultsContract, {
1717
updateTags: {
1818
handler: async (r) => callController(ResultController.updateTags)(r),
1919
},
20-
reportCompletedEventMismatch: {
21-
handler: async (r) =>
22-
callController(ResultController.reportCompletedEventMismatch)(r),
23-
},
2420
deleteAll: {
2521
handler: async (r) => callController(ResultController.deleteAll)(r),
2622
},

frontend/__tests__/test/events/data.spec.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function timerData(
5757
if (event === "step") {
5858
return { event, timer, drift: 0 };
5959
}
60-
return { event, timer };
60+
return { event, timer, date: 0 };
6161
}
6262

6363
describe("data.ts", () => {
@@ -285,18 +285,8 @@ describe("data.ts", () => {
285285
logTestEvent("input", 1010, inputData({ wordIndex: 0, charIndex: 0 }));
286286
logTestEvent("input", 1100, inputData({ wordIndex: 0, charIndex: 1 }));
287287

288-
const perWord = getEventsPerWord(getAllTestEvents(), undefined, 50);
289-
expect(perWord.get(0)).toHaveLength(1);
290-
});
291-
292-
it("respects startMs", () => {
293-
logTestEvent("input", 1010, inputData({ wordIndex: 0, charIndex: 0 }));
294-
logTestEvent("input", 1100, inputData({ wordIndex: 0, charIndex: 1 }));
295-
296288
const perWord = getEventsPerWord(getAllTestEvents(), 50);
297289
expect(perWord.get(0)).toHaveLength(1);
298-
const first = perWord.get(0)?.[0];
299-
expect(first?.type === "input" && first.data.charIndex).toBe(1);
300290
});
301291
});
302292

0 commit comments

Comments
 (0)