Skip to content

refactor: login page (@miodec) #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miodec merged 29 commits into from
Mar 17, 2026
Merged

refactor: login page (@miodec) #7595

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
bda7b6d
wip
Miodec Mar 8, 2026
c1e066f
wip
Miodec Mar 8, 2026
a277cc1
fix notifs, disable
Miodec Mar 8, 2026
1f3e387
disabled support
Miodec Mar 8, 2026
47af31d
fix error handling
Miodec Mar 8, 2026
49ded05
split
Miodec Mar 8, 2026
20d3449
brr
Miodec Mar 8, 2026
360b0b7
use h3
Miodec Mar 9, 2026
3a6781b
use buttons
Miodec Mar 9, 2026
e19677b
use ts/forms
fehmer Mar 12, 2026
2f00214
cleanup
Miodec Mar 12, 2026
5a49f10
remove console log
Miodec Mar 12, 2026
370df73
beep
Miodec Mar 12, 2026
6f89d6a
fix login with google/github
fehmer Mar 12, 2026
b42938d
name
fehmer Mar 12, 2026
f1d2fc5
mixed message
Miodec Mar 12, 2026
8cd99a4
missing strings
Miodec Mar 12, 2026
fdabc8e
review comments
fehmer Mar 12, 2026
2687761
Merge branch 'master' into solid-login
Miodec Mar 12, 2026
bd4ffc6
fix
fehmer Mar 12, 2026
f1b89b3
indicator
Miodec Mar 12, 2026
ddeb76d
catch
Miodec Mar 12, 2026
c3b18be
fix warning from remoteValidation
fehmer Mar 12, 2026
8ce8276
typo
fehmer Mar 12, 2026
ed042e3
comment
Miodec Mar 12, 2026
7052283
message
Miodec Mar 13, 2026
976f96d
tests
Miodec Mar 13, 2026
11e3801
Merge branch 'master' into solid-login
Miodec Mar 17, 2026
50bf1b8
fix merge
Miodec Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"rules": {
"explicit-function-return-type": "off",
"no-explicit-any": "off",
"no-unsafe-assignment": "off"
"no-unsafe-assignment": "off",
"no-empty-function": "off"
Comment on lines +24 to +25
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling typescript/no-empty-function for the whole frontend makes it easy to miss real bugs (empty handlers in production code). If this is only needed for Storybook mocks, prefer file-level/inline disables in storybook/ instead of turning the rule off globally.

Suggested change
"no-unsafe-assignment": "off",
"no-empty-function": "off"
"no-unsafe-assignment": "off"

Copilot uses AI. Check for mistakes.
}
},
{
Expand Down
82 changes: 0 additions & 82 deletions frontend/__tests__/components/ui/ValidatedInput.spec.tsx
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"dependencies": {
"@date-fns/utc": "1.2.0",
"@leonabcd123/modern-caps-lock": "2.2.2",
"@leonabcd123/modern-caps-lock": "3.0.4",
"@monkeytype/contracts": "workspace:*",
"@monkeytype/funbox": "workspace:*",
"@monkeytype/schemas": "workspace:*",
Expand All @@ -37,6 +37,7 @@
"@tanstack/pacer-lite": "0.2.1",
"@tanstack/query-db-collection": "1.0.27",
"@tanstack/solid-db": "0.2.10",
"@tanstack/solid-form": "1.28.4",
"@tanstack/solid-query": "5.90.23",
"@tanstack/solid-query-devtools": "5.91.3",
"@tanstack/solid-table": "8.21.3",
Expand Down
100 changes: 0 additions & 100 deletions frontend/src/html/pages/login.html
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion frontend/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
<mount data-component="aboutpage"></mount>
</div>
<load src="html/pages/settings.html" />
<load src="html/pages/login.html" />
<div class="page pageLogin hidden" id="pageLogin">
<mount data-component="loginpage"></mount>
</div>
<load src="html/pages/account.html" />

<div class="page pageProfile hidden" id="pageProfile">
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/styles/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@

@layer custom-styles {
@import "buttons", "404", "ads", "account", "animations", "caret",
"commandline", "core", "fonts", "inputs", "keymap", "login", "monkey",
"popups", "scroll", "settings", "account-settings", "test", "loading",
"friends", "media-queries";
"commandline", "core", "fonts", "inputs", "keymap", "monkey", "popups",
"scroll", "settings", "account-settings", "test", "loading", "friends",
"media-queries";

.chartCanvas {
width: 100% !important;
Expand Down
79 changes: 0 additions & 79 deletions frontend/src/styles/login.scss
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions frontend/src/styles/tailwind.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,14 @@
padding: 0;
}
}

@layer utilities {
.autofill-fix:-webkit-autofill,
.autofill-fix:-webkit-autofill:hover,
.autofill-fix:-webkit-autofill:focus {
@apply border-none font-(--font) caret-(--text-color) font-[inherit];
outline: 0.15em solid var(--main-color);
-webkit-text-fill-color: var(--text-color);
-webkit-box-shadow: 0 0 0 1000000px var(--sub-alt-color) inset;
}
}
Loading
Loading