Skip to content

fix(profile): fix pb table hover overlay flickering and not covering content (@Mubashir21) #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mubashir21 wants to merge 1 commit into from
Closed

fix(profile): fix pb table hover overlay flickering and not covering content (@Mubashir21) #7602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions frontend/src/ts/components/pages/profile/UserProfile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { createMemo, For, JSXElement, Show } from "solid-js";

import * as PbTablesModal from "../../../modals/pb-tables";
import { getConfig } from "../../../signals/config";
import { cn } from "../../../utils/cn";
import { Formatting } from "../../../utils/format";
import { formatTopPercentage } from "../../../utils/misc";
import { Button } from "../../common/Button";
Expand Down Expand Up @@ -126,8 +127,10 @@ function PbTable<M extends "time" | "words">(props: {
<div class="grid grid-cols-2 gap-8 p-4 md:grid-cols-4">
<For each={bests()}>
{(item) => (
<div class="grid items-center">
<div class="col-start-1 row-start-1 text-center">
<div
class={cn("grid items-center", item.pb !== undefined && "group")}
>
<div class="col-start-1 row-start-1 text-center transition-opacity group-hover:opacity-0">
<div class="text-xs text-sub">
{item.mode2} {props.mode === "time" ? "seconds" : "words"}
</div>
Expand All @@ -143,7 +146,7 @@ function PbTable<M extends "time" | "words">(props: {
</div>
</div>
<Show when={item.pb !== undefined}>
<div class="col-start-1 row-start-1 grid bg-sub-alt text-center text-xs opacity-0 transition-opacity hover:opacity-100">
<div class="col-start-1 row-start-1 grid h-full bg-sub-alt text-center text-xs opacity-0 transition-opacity group-hover:opacity-100">
<div class="text-sub">
{item.mode2} {props.mode === "time" ? "seconds" : "words"}
</div>
Expand Down